ASP.NET MVC / Web API / Web Pages

Created Issue: Remove EditorFor HTML attribute handling inconsistencies [1434]

dougbu — Wed, 20 Nov 2013 06:10:22 GMT

Two issues to address:
1. Default collection and complex object editor templates ignore the "htmlAttribute" key in view data. This causes consistent application of `@Html.EditorFor(… , new { htmlAttribute = new { @class = "form-control" } })` for all properties of the following model:
``` C#
public class Higher
{
public int Id { get; set; }

public string HName1 { get; set; }

public Middle HValue { get; set; }

public string HName2 { get; set; }
}
```
to result in inconsistent HTML -- some `<input/>` elements with the requested class, some without. See attached InconsistentHtml.png file for the visible effect of this inconsistency.

2. The name of the view data key in `@Html.EditorFor(... , new { htmlAttribute = new { @class = "form-control" } })` is inconsistent with the very similar parameter name in (for e.g.) `@Html.TextBoxFor(... , htmlAttributes: new { @class = "form-control" })`. Rename the view data key to make it also plural -- "htmlAttributes".

Commented Issue: CompareAttribute does not use custom error messages [1401]

dougbu — Wed, 20 Nov 2013 05:38:37 GMT

__Scenario:__
User likes to customise/localise the error message for the Data Annotations CompareAttribute in a view model.

__Issue:__
When the Data Annotations Compare attribute (System.ComponentModel.DataAnnotations.CompareAttribute) is used with custom error messages, the custom error messages are never shown, instead the default error message is always shown.

Example model:
```
private class ExampleModelWithCustomErrorMessage
{
[Compare("OtherProperty", ErrorMessage = "Custom error message")]
public string MyProperty { get; set; }

public string OtherProperty { get; set; }
}
```

same issue with error message from a resource, i.e.

```
private class ExampleModelWithCustomErrorMessageFromResource
{
[Compare("OtherProperty", ErrorMessageResourceType = typeof(Resource.Resource), ErrorMessageResourceName = "ResourceKey"))]
public string MyProperty { get; set; }

public string OtherProperty { get; set; }
}
```

The above examples will both print the default error message _'MyProperty' does not match 'OtherProperty'_.

__Reason:__
CompareAttributeWrapper in CompareAttributeAdapter does not copy over the custom error message properties when creating a new, wrapped CompareAttribute.

New unit test in CompareAttributeAdapterTest.cs:
```
[Fact]
public void ClientRulesWithCompareAttribute_ErrorMessageCanBeCustomised()
{
// Arrange
const string expectedErrorMessage = "Computer says no";
var metadata = ModelMetadataProviders.Current.GetMetadataForProperty(() => null, typeof(PropertyNameModel), "MyProperty");
var context = new ControllerContext();
var attribute = new System.ComponentModel.DataAnnotations.CompareAttribute("OtherProperty")
{
ErrorMessage = expectedErrorMessage
};

var adapter = new CompareAttributeAdapter(metadata, context, attribute);

// Act
var rules = adapter.GetClientValidationRules()
.OrderBy(r => r.ValidationType)
.ToArray();

// Assert
ModelClientValidationRule rule = Assert.Single(rules);
Assert.Equal(expectedErrorMessage, rule.ErrorMessage);
}
```

Here is also an attempt at fixing the issue (CompareAttributeAdapter.cs:37)
```
public CompareAttributeWrapper(DataAnnotationsCompareAttribute attribute, ModelMetadata metadata)
: base(attribute.OtherProperty)
{
ErrorMessage = attribute.ErrorMessage;
ErrorMessageResourceType = attribute.ErrorMessageResourceType;
ErrorMessageResourceName = attribute.ErrorMessageResourceName;

_otherPropertyDisplayName = attribute.OtherPropertyDisplayName;
if (_otherPropertyDisplayName == null && metadata.ContainerType != null)
{
_otherPropertyDisplayName = ModelMetadataProviders.Current.GetMetadataForProperty(() => metadata.Model, metadata.ContainerType, attribute.OtherProperty).GetDisplayName();
}
}
```
Comments: Fixed in commit [5003c3a8eff3](https://aspnetwebstack.codeplex.com/SourceControl/changeset/5003c3a8eff3be63a63cccdec31dd24aa2ebe1a1).

Edited Issue: CompareAttribute does not use custom error messages [1401]

dougbu — Wed, 20 Nov 2013 05:38:37 GMT

Commented Issue: Throw error message when users try to supply handlers(IRouteHandler or Message handlers) when using attribute routing [1428]

davidmatson — Wed, 20 Nov 2013 01:07:48 GMT

Handlers like IRouteHandler in MVC and HttpMessageHandler in Web API do not work with attribute routing. A user implementing IDirectRouteProvider might supply these handlers even though these handlers would never work. Instead of this we can throw an error message upfront when building the route table so that users know the issue rather than spending hours to detect this.
Comments: commit aa25b83909680094b75a58b316eed267dcf42c93

Edited Issue: Throw error message when users try to supply handlers(IRouteHandler or Message handlers) when using attribute routing [1428]

davidmatson — Wed, 20 Nov 2013 01:07:48 GMT

Commented Issue: Make sure HttpConfiguration instance is disposed in Owin selfhost scenario. [1427]

davidmatson — Wed, 20 Nov 2013 01:07:30 GMT

Diposable resources like message handlers, services etc should be disposed when our Owin adapter gets disposed.

Attached a katana selfhost repro
Comments: commit 30607385885e68db21c7d0ebc8337444d9e9d5dc

Edited Issue: Make sure HttpConfiguration instance is disposed in Owin selfhost scenario. [1427]

davidmatson — Wed, 20 Nov 2013 01:07:30 GMT

Diposable resources like message handlers, services etc should be disposed when our Owin adapter gets disposed.

Attached a katana selfhost repro

Source code checked in, #30607385885e68db21c7d0ebc8337444d9e9d5dc

davidmatson — Wed, 20 Nov 2013 01:04:56 GMT

Implement cleanup correctly in OWIN middleware (fixes #1427). OWIN does not call Dispose on middleware; instead, it signals a host.OnAppDisposing cancellation token. Register the Web API OWIN middleware for cleanup with that mechanism.

Closed Issue: Throw during startup when a route constraint is of the wrong type [1383]

kichalla — Wed, 20 Nov 2013 01:04:19 GMT

Only IHttpRouteConstraint and string are supported. Especially with attribute routing, we shouldn't wait until a matching request comes in to tell the developer about the incorrect app code.
Comments: Verified.

Reviewed: v5.0 RTM (十一月 19, 2013)

wutao — Wed, 20 Nov 2013 01:00:10 GMT

Rated 3 Stars (out of 5) - download download download

Commented Issue: Multipart parser unable to parse mutlipart content when it does not end with CRLF [1433]

kamehrot — Wed, 20 Nov 2013 00:32:32 GMT

_Scenario_:
User is trying to use Uploadify tool to do multipart form data uploads.

_Reference_:
Following discussion thread is about the issue
https://aspnetwebstack.codeplex.com/discussions/354215

_Issue_:
The request sent by Uploadify tool does not have a ending CRLF which causes issues in our multipart parser resulting in the error "Error writing MIME multipart body part to output stream"

_Attached_ the following docs:
1. Fiddler session related to Uploadify tool request. I traced this request from a public demo sample that www.Uplaodify.com site has
2. A web api katana selfhost service which accepts the above fiddler request.

Note: if you add a CRLF to the end the last multipart, then this scenario works fine.
Comments: Refer to https://aspnetwebstack.codeplex.com/workitem/232 as well that was opened earlier for this issue.

Closed Feature: Expose route builder in both MVC and Web API attribute routing [1360]

kichalla — Wed, 20 Nov 2013 00:17:10 GMT

__Scenario__:
http://stackoverflow.com/questions/19529522/httproutebuilder-where-did-it-go-and-why

Please note about the following bug too when trying to fix this:
http://aspnetwebstack.codeplex.com/workitem/1212
Comments: Verified. See comments for more info.

Source code checked in, #aa25b83909680094b75a58b316eed267dcf42c93

davidmatson — Tue, 19 Nov 2013 23:59:42 GMT

Incorporate code review feedback (fixes #1428).

Edited Issue: Multipart parser unable to parse mutlipart content when it does not end with CRLF [1433]

kichalla — Tue, 19 Nov 2013 23:57:39 GMT

Edited Issue: Multipart parser unable to parse mutlipart content when it does not end with CRLF [1433]

kichalla — Tue, 19 Nov 2013 23:57:12 GMT

_Scenario_:
User is trying to use Uploadify tool to do multipart form data uploads.

__Reference__:
Following discussion thread is about the issue
https://aspnetwebstack.codeplex.com/discussions/354215

__Issue__:
The request sent by Uploadify tool does not have a ending CRLF which causes issues in our multipart parser resulting in the error "Error writing MIME multipart body part to output stream"

_Attached_ the following docs:
1. Fiddler session related to Uploadify tool request. I traced this request from a public demo sample that www.Uplaodify.com site has
2. A web api katana selfhost service which accepts the above fiddler request.

Note: if you add a CRLF to the end the last multipart, then this scenario works fine.

Created Issue: Multipart parser unable to parse mutlipart content when it does not end with CRLF [1433]

kichalla — Tue, 19 Nov 2013 23:56:14 GMT

Commented Issue: Add BsonFormatter in MediaTypeFormatterCollection [1430]

dougbu — Tue, 19 Nov 2013 23:50:12 GMT

MediaTypeFormatterCollection has properties for JsonMediaTypeFormatter, XmlMediatypeformatter and FormUrlEncodedMediaTypeFormatter too. Since we added support for BsonMediaTypeFormatter, we should add it to this class too.

Comments: Suggest this bug should not be fixed in 5.1. Adding the BSON formatter to the `MediaTypeFormatterCollection` will change the behavior of existing WebAPI services, breaking back-compatibility. We can do this in a more major release, where BSON support won't be a surprise. Workaround is to configure a new `BsonMediaTypeFormatter` instance and add it to the default `Formatters` collection.

Source code checked in, #5003c3a8eff3be63a63cccdec31dd24aa2ebe1a1

dougbu — Tue, 19 Nov 2013 23:49:25 GMT

Preserve error message when creating CompareAttributeWrapper (fixes #1401) - http://aspnetwebstack.codeplex.com/workitem/1401 - "CompareAttribute does not use custom error messages" - Copy properties over in CompareAttributeWrapper constructor

Edited Feature: Expose route builder in both MVC and Web API attribute routing [1360]

davidmatson — Tue, 19 Nov 2013 23:27:46 GMT

Edited Issue: Flow the ClientDisconnectedToken in Web Host [858]

davidmatson — Tue, 19 Nov 2013 23:27:20 GMT

With [this commit](http://aspnetwebstack.codeplex.com/SourceControl/changeset/c18dbd8306a2), it's now possible to flow the following two CancellationToken objects through the ASP.NET Web API pipeline under ASP.NET host:

```
public override Task ProcessRequestAsync(HttpContext context) {

CancellationTokenSource cancellationTokenSource = CancellationTokenSource.CreateLinkedTokenSource(
context.Request.TimedOutToken,
context.Response.ClientDisconnectedToken);

//...

}
```

Edit: We'd like to flow ClientDisconnectedToken, but we're waiting on a reliability fix for it to be published first. For TimedOutToken, that's something that could be pretty easily added in code via Web API, which is probably better than tying to a web.config setting.