ASP.NET MVC / Web API / Web Pages

Reviewed: v5.2 RTM (Sep 20, 2014)

thanhcdth — Sun, 21 Sep 2014 02:44:37 GMT

Rated 2 Stars (out of 5) - Very good.................

Closed Issue: [perf] System.net.Http.Formatting.ReadAsAsync [2092]

sornaks — Fri, 19 Sep 2014 22:08:18 GMT

From a user -

When using the following in a client scenario

```c#
var item = await content.ReadAsAsync<TestData>();
```

The call may take 100s of milliseconds for the first call, and subsequently the same on every call.

but if you precreate the JsonMediaTypeFormatter and call

```c#
var item = await content.ReadAsAsync<TestData>(new [] { JsonMediaTypeFormatter } );
```

The first call will still be expensive but the following calls will be sub-millisecond.

I reproduced the issue, and it comes down to the fact that the contractresolver is not being cached when we new up a new formatter, I'm attaching a sample that shows the timing based on what is being cached.

Unfortunately if we start caching the contractresolver across serializer instances, we introduce a breaking change behavior when the contract is different per serializer.

We can consider however caching the ```JsonMediaTypeFormatter``` in a static for this method calls only.

Comments: https://aspnetwebstack.codeplex.com/SourceControl/network/forks/sornaks/ReadAsAsyncPerfImprovement/contribution/7453

Commented Issue: [perf] System.net.Http.Formatting.ReadAsAsync [2092]

sornaks — Fri, 19 Sep 2014 22:07:41 GMT

From a user -

When using the following in a client scenario

```c#
var item = await content.ReadAsAsync<TestData>();
```

The call may take 100s of milliseconds for the first call, and subsequently the same on every call.

but if you precreate the JsonMediaTypeFormatter and call

```c#
var item = await content.ReadAsAsync<TestData>(new [] { JsonMediaTypeFormatter } );
```

The first call will still be expensive but the following calls will be sub-millisecond.

I reproduced the issue, and it comes down to the fact that the contractresolver is not being cached when we new up a new formatter, I'm attaching a sample that shows the timing based on what is being cached.

Unfortunately if we start caching the contractresolver across serializer instances, we introduce a breaking change behavior when the contract is different per serializer.

We can consider however caching the ```JsonMediaTypeFormatter``` in a static for this method calls only.

Comments: Pushed. https://aspnetwebstack.codeplex.com/SourceControl/network/forks/sornaks/ReadAsAsyncPerfImprovement/contribution/7453

Edited Issue: 'Microsoft.jQuery.Unobtrusive.Validation' installation fails because it is unable to find a version of Microsoft.JQuery.Unobtrusive.Validation compatible to JQuery 1.4.1 [2048]

yishaigalatzer — Fri, 19 Sep 2014 20:16:03 GMT

Microsoft.JQuery.Unobtrusive.Validation requires JQuery >=1.8 and JQuery.Validation >=1.8. But, JQuery.Validation (1.8) needs jQuery (≥ 1.3.2 && ≤ 1.6). Because of this, when NuGet installs the JQuery 1.8 and JQuery.Validation 1.8 at the same time, it fails.
The workaround is installing newer vesions of JQuery before installing the package.

Source code checked in, #a0eb22a4b74bee7c9e909839ffb6497a0d05315c

Ryan Nowak — Fri, 19 Sep 2014 20:06:56 GMT

Issue #2092 - [perf] System.net.Http.Formatting.ReadAsAsync - Using the JsonMediaTypeFormatter for the first time is rather expensive (due to reflection cost when creating the default contract resolver). Hence we new up a static collection, such that the second call is much faster.

Commented Unassigned: Same thing [2140]

ashes267 — Fri, 19 Sep 2014 10:06:55 GMT

Hello ,
Im trying to develop some facebook application using asp.net MVC ,but As all people discussed in another forum, the [FacebookAuthorize("email", "user_photos") in the facebook app template produces the error : Newtonsoft.Json.JsonReaderException: Could not convert string to integer: installed. Path 'data[0].permission', line 1, position 34

then i found the new nightly build of the sdk fixed this issue and i installed it on my application but now i have another issue , it give me :
Server Error in '/' Application.

Value cannot be null.
Parameter name: appSecret

even i have all the configs set in my web.config

anybody can help me with this please ?
Comments: Well I followed all instructions given on this https://aspnetwebstack.codeplex.com/workitem/1935 help page and I am receiving the same above error as mentioned .. I have simply created a basic facebook application as suggested in http://www.asp.net/mvc/tutorials/mvc-4/aspnet-mvc-facebook-birthday-app this tutorial .. So both the tutorials and links are provided by microsoft and not some third party . So why do you need a project to evaluate our concern related to the same above query as posted by the user. Besides this I can upload a 11 MB project ..( Project has been created using the tutorial instructions )

Created Unassigned: Same thing [2140]

ashes267 — Fri, 19 Sep 2014 10:05:26 GMT

Commented Unassigned: Microsoft.aspnet.facebook Value cannot be null. Parameter name: appSecret [2026]

ashes267 — Fri, 19 Sep 2014 10:04:05 GMT

Reviewed: v4.0 RTM (九月 18, 2014)

juncos — Fri, 19 Sep 2014 05:18:38 GMT

Rated 4 Stars (out of 5) - jjjzheshige ceshi

Commented Feature: Help pages for odata controllers [1892]

coolnsdc — Thu, 18 Sep 2014 20:25:05 GMT

I would like to request that the help pages, like on standard asp.net web api be provided for odata controllers as well. Currently the tooling does not work for odata.

http://stackoverflow.com/questions/23087628/asp-net-web-api-help-pages-showing-no-content-for-odata-controllers

Comments: I would love to see the ApiExplorer handle OData controllers as well!

Edited Issue: RedirectToAction can't find any route defined with custom route attributes [2129]

danroth27 — Thu, 18 Sep 2014 16:52:23 GMT

Custom route attributes created by extending RouteFactoryAttribute are not "seen" when using RedirectToAction in MVC 5.2, therefor an exception is raised when trying to match routes, which says that the route for the action was not found in the routes table.

It is worth mentioning that:
- I have not declared any traditional MVC route just attribute ones
- Normal requests work as expected

PS. Using the RouteAttribute makes everything work as expected

Commented Unassigned: Web Api should support anonymous types for xml serialization [2123]

Togakangaroo — Thu, 18 Sep 2014 15:05:22 GMT

When a web api method returns an anonymous type it cannot be serialized to xml. This is a complete "are you kidding me" situation. It is very common to try to test newly created routes by popping the url in the browser, the error is far from clear, and incompatibility with the Xml serializer is not an issue anyone would have any reason to expect.

I probably spent close to 30 minutes trying to figure it out before googing "anonyomous types and web api" and I cannot possibly be the only one. Whoever did this should feel bad for wasting everyone's time.

In all seriousness though, is there a good reason for the lack of this feature? If I was to code it up and contribute back, what should I be on the lookout for?

Comments: Thanks. That's a really great response letting me know the way forward. I put together something really quick for this using [XSerializer](http://www.nuget.org/packages/XSerializer/) but nothing I'd want to publish yet (ie I've hardly tested it at all). It seems that what this really amounts to is that by default Web Api uses a deprecated (or at least an abandoned) xml serializer. If nothing else, can I recommend a big warning somewhere about this along with some possible solutions? In my application's case, I realized I didn't need xml serialization (it was only being used when I hit an api route directly with the browser), and removing it worked out fine.

Commented Issue: [MVC 5.2] Rendering child action with direct route does not set ControllerContext.IsChildAction [2136]

Ukyo — Thu, 18 Sep 2014 14:58:58 GMT

Reviewed: v5.2 RTM (九月 18, 2014)

youzusong — Thu, 18 Sep 2014 10:43:34 GMT

Rated 5 Stars (out of 5) - Thank you!

Source code checked in, #34351c2f427b7ddb2c1562508177c0b0f8c7c1c7

Sam Xu — Thu, 18 Sep 2014 08:35:05 GMT

Upgrade DataLib version from 6.5.0 to 6.7.0 Here's the annuncement of ODataLib 6.7.0 release: http://blogs.msdn.com/b/odatateam/archive/2014/09/05/announcement-odatalib-6-7-0-release.aspx

Commented Issue: Batch's inner request's Url not being decoded in WebHost scenarios [2103]

nowakra — Wed, 17 Sep 2014 23:26:22 GMT

In the following example, the subrequest url is like '/api/values/Hello%20World' and the value that is echoed in the batch response is __"Hello World"__...but for the same request, we receive the response as __"Hello%20World"__ in case of WebHost

I debugged more and found that the issue is when getting the route data for the sub requests…in case of webhost we rely on System.Web’s route collection to get the route data and the corresponding route values are _not_ in decoded format…

Example (__self host__ batch request and response)

Request:
```
POST http://kcthinkpad:9095/api/batch HTTP/1.1
Content-Type: multipart/mixed; boundary="b66c6846-0bc0-4cd1-b232-05859c98e5a3"
Host: kcthinkpad:9095
Content-Length: 200
Expect: 100-continue
Connection: Keep-Alive

--b66c6846-0bc0-4cd1-b232-05859c98e5a3
Content-Type: application/http; msgtype=request

GET /api/values/Hello%20World HTTP/1.1
Host: kcthinkpad:9095

--b66c6846-0bc0-4cd1-b232-05859c98e5a3--

```
Response:
```
HTTP/1.1 200 OK
Content-Length: 215
Content-Type: multipart/mixed; boundary="f4a92586-1094-4705-bd12-0b458db925fc"
Server: Microsoft-HTTPAPI/2.0
Date: Sat, 09 Aug 2014 23:27:58 GMT

--f4a92586-1094-4705-bd12-0b458db925fc
Content-Type: application/http; msgtype=response

HTTP/1.1 200 OK
Content-Type: application/json; charset=utf-8

"Hello World"
--f4a92586-1094-4705-bd12-0b458db925fc--

```
Comments: Fixed with 510fa58406be829e4e3a508298f9f27ee76079f1

Edited Issue: Batch's inner request's Url not being decoded in WebHost scenarios [2103]

nowakra — Wed, 17 Sep 2014 23:26:22 GMT

Source code checked in, #510fa58406be829e4e3a508298f9f27ee76079f1

Ryan Nowak — Wed, 17 Sep 2014 23:22:07 GMT

Fix for Codeplex-2103 - Batch's inner request's Url not being decoded in WebHost scenarios The issue here is that when we do batching in a Web Host scenario, we delegate to the System.Web route table - we do this by wrapping each HttpRequestMessage in a wrapper that implements HttpRequestBase. Our adapter isn't doing the right thing with respect to escaping. This change brings the adapter into compliance and adds an integration test.

Commented Issue: [MVC 5.2] Rendering child action with direct route does not set ControllerContext.IsChildAction [2136]

nowakra — Wed, 17 Sep 2014 21:11:46 GMT

Hello!
So I have some logic in my mvc 5.2 app that relies heavily on ControllerContext.IsChildAction property of my controller classes. Ater moving to new mvc with built in attribute routing I started to see that logic failing. I render some actions using HtmlHelper.Action, and that action has ControllerContext.IsChildAction set to false. The action has route attribute. No problems with rendering those actions, who does not have route attributes. ControllerContext.IsChildAction is true if RouteData.DataTokens contains key "ParentActionViewContext". Somehow, if you use direct route, parent actionViewContext is not pushed into route data. I traced the problem down to CreateRouteData method inside ChildActionExtensions.cs of the mvc 5.2., and found this:

```
// It's possible that the outgoing route is a direct route - in which case it's not possible to reach using
// the action name and controller name. We need to check for that case to determine if we need to create a
// 'direct route' routedata to reach it.
if (route.IsDirectRoute())
{
return RouteCollectionRoute.CreateDirectRouteMatch(route, new List<RouteData>() { routeData });
}
else
{
return routeData;
}
```

Somehow, that RouteCollectionRoute.CreateDirectRouteMatch method forgets to add parent view context in data tokens.
Comments: Thanks! I can see the problem now. The issue here is that attribute routing works a little differently. The contract of traditional MVC is that a controller is selected using a name based on the route value of 'controller' and then an action is selected using a name based on the route value of 'action'. All of the apis of the framework are based on this assumption, which don't structurally work with attribute routing. The 'action' isn't really decided until we get into ControllerActionInvoker.FindAction - it's here that we set the 'real' route data that actually matches what will run. You should consider using the OnActionExecuting method on Controller instead of initialize if it's appropriate. For instance if you are doing anything else with route data in your initialize method, you'll find more differences in behavior between attribute routing and convention routing, that we're unlikely to address.

Commented Issue: HttpMessageInvoker object disposed exception [2091]

kichalla — Wed, 17 Sep 2014 20:51:15 GMT

Hello,

I am hosting a Web API REST service using Owin and a typical startup class, for example:

```
public void Configuration(IAppBuilder builder)
{
System.Diagnostics.Debug.WriteLine("Startup - Configuring the HttpServer.");
var server = new HttpServer();
WebApiConfig.Register(server);
builder.UseWebApi(server);
builder.UseStageMarker(PipelineStage.Authenticate);
}
```

This all works well, however I have noticed that every now and then on the very 1st request to the service I see the following error:

```
<html>
<head>
<title>Cannot access a disposed object.<br>Object name: 'System.Net.Http.HttpMessageInvoker'.</title>
<meta name="viewport" content="width=device-width" />
<style>
body {font-family:"Verdana";font-weight:normal;font-size: .7em;color:black;}
p {font-family:"Verdana";font-weight:normal;color:black;margin-top: -5px}
b {font-family:"Verdana";font-weight:bold;color:black;margin-top: -5px}
H1 { font-family:"Verdana";font-weight:normal;font-size:18pt;color:red }
H2 { font-family:"Verdana";font-weight:normal;font-size:14pt;color:maroon }
pre {font-family:"Consolas","Lucida Console",Monospace;font-size:11pt;margin:0;padding:0.5em;line-height:14pt}
.marker {font-weight: bold; color: black;text-decoration: none;}
.version {color: gray;}
.error {margin-bottom: 10px;}
.expandable { text-decoration:underline; font-weight:bold; color:navy; cursor:hand; }
@media screen and (max-width: 639px) {
pre { width: 440px; overflow: auto; white-space: pre-wrap; word-wrap: break-word; }
}
@media screen and (max-width: 479px) {
pre { width: 280px; }
}
</style>
</head>

<body bgcolor="white">

<span><H1>Server Error in '/' Application.<hr width=100% size=1 color=silver></H1>

<h2> <i>Cannot access a disposed object.<br>Object name: 'System.Net.Http.HttpMessageInvoker'.</i> </h2></span>

<font face="Arial, Helvetica, Geneva, SunSans-Regular, sans-serif ">

<b> Description: </b>An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

<br><br>

<b> Exception Details: </b>System.ObjectDisposedException: Cannot access a disposed object.<br>Object name: 'System.Net.Http.HttpMessageInvoker'.<br><br>

<b>Source Error:</b> <br><br>

<table width=100% bgcolor="#ffffcc">
<tr>
<td>
<code>

An unhandled exception was generated during the execution of the current web request. Information regarding the origin and location of the exception can be identified using the exception stack trace below.</code>

</td>
</tr>
</table>

<br>

<b>Stack Trace:</b> <br><br>

<table width=100% bgcolor="#ffffcc">
<tr>
<td>
<code><pre>

[ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Http.HttpMessageInvoker'.]
System.Net.Http.HttpMessageInvoker.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken) +426915
System.Web.Http.Owin.<InvokeCore>d__0.MoveNext() +1561
System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw() +32
Microsoft.Owin.Host.SystemWeb.Infrastructure.ErrorState.Rethrow() +62
Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.StageAsyncResult.End(IAsyncResult ar) +185
Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.IntegratedPipelineContext.EndFinalWork(IAsyncResult ar) +55
System.Web.AsyncEventExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() +434
System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously) +288
</pre></code>

</td>
</tr>
</table>

<br>

<hr width=100% size=1 color=silver>

<b>Version Information:</b> Microsoft .NET Framework Version:4.0.30319; ASP.NET Version:4.0.30319.34009

</font>

</body>
</html>

[ObjectDisposedException]: Cannot access a disposed object.
Object name: 'System.Net.Http.HttpMessageInvoker'.
at System.Net.Http.HttpMessageInvoker.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
at System.Web.Http.Owin.HttpMessageHandlerAdapter.<InvokeCore>d__0.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
at Microsoft.Owin.Host.SystemWeb.Infrastructure.ErrorState.Rethrow()
at Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.StageAsyncResult.End(IAsyncResult ar)
at Microsoft.Owin.Host.SystemWeb.IntegratedPipeline.IntegratedPipelineContext.EndFinalWork(IAsyncResult ar)
at System.Web.HttpApplication.AsyncEventExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute()
at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)
```

I added some basic debug logging statements to the application and saw that on the first request my logging statement "Startup - Configuring the HttpServer" is output as expected, and I see the error I mentioned. Then on the second request I make I see the logging statement again and the request succeeds without error.

This leads me to believe that for some reason the Owin runtime components are being disposed during the first request and need to be re-created during the second request. I have only produced this with the Azure emulator so far with the following steps, and it is not re-producible every time.

1. Ensure debugger is stopped.
2. Ensure both compute and storage emulators are stopped.
3. Clean and rebuild my solution.
4. Start debugging which also deploys to emulator.
5. Send first request, observe owin runtime created and exception -> doesn't happen every time, maybe 1 times out of 20.
6. Send second request and observer owin runtime created and no exception.
Comments: @thebothead: Thanks for reporting the issue. I see that you are trying to use Web API OWIN adapter(System.Web.Http.Owin.dll) in IIS. This is not a supported scenario. The "System.Web.Http.Owin.dll" is meant to be used when self-hosting. Can you please elaborate as to what is the scenario that you are trying here?