Skip to content

Fix to use "Regenerate" button label and loading state in Title Generation modal#790

Merged
dkotter merged 5 commits into
WordPress:developfrom
Intenzi:fix/title-generation-modal-button-label
Jun 29, 2026
Merged

Fix to use "Regenerate" button label and loading state in Title Generation modal#790
dkotter merged 5 commits into
WordPress:developfrom
Intenzi:fix/title-generation-modal-button-label

Conversation

@Intenzi

@Intenzi Intenzi commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

What?

Closes #788

Changes button label inside Title Generation modal to "Regenerate" with "Regenerating.." state on click.

Why?

Fixes the User Experience issue where the modal button is provided for regeneration of title. But the button states Generate instead.

How?

  • Set "Regenerate" and "Regenerating..." labels for the button modal.
  • Uses isRegenerating variable to decide between the two.

Use of AI Tools

AI assistance: Yes
Tool(s): Antigravity IDE
Model(s): Gemini 3.5 Flash (Low)
Used for: Identifying the relevant code file for the fix. Final implementation was reviewed and edited by me.

Testing Instructions

  1. Enable Title Generation Experiment.
  2. Make a post with sufficient content for Title generation.
  3. Click on Generate button to generate Title.
  4. A popup modal shows up which asks if you want to regenerate a new title.
  5. The button in the popup modal now shows up as "Regenerate"
  6. Clicking the Regenerate button here, now shows "Regenerating..."

Screenshots or screencast

Before After
image image
image image

Changelog Entry

Fixed - Visual Generate button in modal to display Regenerate instead.

Open WordPress Playground Preview

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Intenzi <[email protected]>
Co-authored-by: jeffpaul <[email protected]>
Co-authored-by: dkotter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.48%. Comparing base (d400910) to head (d3ab6d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #790   +/-   ##
==========================================
  Coverage      76.48%   76.48%           
  Complexity      1869     1869           
==========================================
  Files             89       89           
  Lines           7990     7990           
==========================================
  Hits            6111     6111           
  Misses          1879     1879           
Flag Coverage Δ
unit 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeffpaul jeffpaul added this to the 1.1.0 milestone Jun 26, 2026
jeffpaul
jeffpaul previously approved these changes Jun 26, 2026

@jeffpaul jeffpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well via Playground

@jeffpaul jeffpaul requested a review from dkotter June 26, 2026 20:07
Comment thread src/experiments/title-generation/components/TitleToolbar.tsx Outdated
@Intenzi

Intenzi commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Labels displayed now are:
Regenerate where applicable:
image
image

Generating... instead of Regenerating...
image

@dkotter dkotter merged commit 9769b49 into WordPress:develop Jun 29, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Title Generation modal button incorrectly uses "Generate/Generating..." instead of "Regenerate/Regenerating..."

3 participants