Block Library: unwrap Classic block migration notice experiment#78165
Conversation
|
Note: This PR is part of Experiment 1 (WP 7.1 Classic block deprecation, #78067) and may need updates as the experiment evolve, particularly when additional migration paths for existing Classic block instances are finalized. This PR can be amended or followed up on before the experiment is ready to fully launch. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@im3dabasia, Thanks for the contribution! I think it's a little too early to unwrap this experiment though, especially since it hasn't even shipped in a release yet. We’d like to give it a bit more time to bake - review the user-facing copy, gather feedback from users, and potentially iterate on the experience before making it the default for everyone. Also, it looks like one of the e2e tests is currently failing. |
tyxla
left a comment
There was a problem hiding this comment.
Agreed with @yuliyan. It's a bit early to unwrap; we'd like to ship this as an experimend and run with it for a while, while also getting feedback and improving it on the way. Unwrapping the experiment is the last step when we're confident that the experiment is doing well and is ready for production.
|
Sure, I am aligning with your opinions. I will update this PR once we are ready to unwrap this experiment and roll it out live for everyone in the GB plugin. Thanks for the quick reviews. I really appreciate them! |
|
Thanks again for your work here @im3dabasia! I'm doing a last test/review pass on this one and will proceed with shipping so we can include it in WordPress 7.1. |
The Convert to blocks toolbar button was removed; the equivalent action is now the primary button in the MigrationNotice. Update the e2e test to click that button in the canvas instead of the block toolbar.
tyxla
left a comment
There was a problem hiding this comment.
LGTM, thanks again @im3dabasia 🙌
|
Thanks @tyxla for taking forward this PR. I really appreciate it! Have a good day! |
Please note
What?
Follow up to #78090
Removes the
gutenberg-classic-block-deprecationexperiment gate so the Classic block migration notice ships to all users by default.Why?
Testing Instructions
<!-- wp:freeform --><p>Hello</p><!-- /wp:freeform -->, switch to Visual editor.