Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim#78484
Conversation
…() as deprecated shim In WordPress#74853 the function was removed from packages/block-library/src/navigation-submenu/index.php without a _deprecated_function() notice. Once that change synced into Core (wordpress-develop WordPress#10865, scheduled for WP 7.0), themes and plugins that called the function — for example from a render_block_core/navigation-submenu filter — started fatal-erroring. This restores it as a thin wrapper that triggers _deprecated_function() and returns block_core_shared_navigation_render_submenu_icon(), the new shared helper that replaced it. Adding it to the shared file means it's available wherever the original was previously rendered. A phpunit test asserts the deprecation notice fires and the return value matches the new helper. Trac ticket: https://core.trac.wordpress.org/ticket/65287
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ecairol! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
PHPCS in packages/block-library/src/navigation-link/shared/ enforces a function-name prefix of block_core_shared*, which forbids the deprecation shim's name. Move the shim into navigation-submenu/index.php (where the function originally lived and block_core_navigation_submenu_* is allowed), guarded by function_exists so a future Core sync that brings the shim back into Core doesn't double-declare. Drop the require_once in the test — its path resolution differed from the plugin's own init load and was triggering "Cannot redeclare" fatals against the already-loaded block_core_shared_navigation_render_submenu_icon(). Normal plugin boot loads navigation-submenu/index.php during block registration, so the shim is available to the test without an explicit require.
The build prefixes packages/block-library functions with gutenberg_ before the plugin loads them, so in the plugin test env the shim exists as gutenberg_block_core_navigation_submenu_render_submenu_icon, not the unprefixed Core name. Match the existing block-navigation-link-variations test convention of asserting on the prefixed name with setExpectedDeprecated().
| * | ||
| * @return string SVG markup for the submenu icon. | ||
| */ | ||
| function block_core_navigation_submenu_render_submenu_icon() { |
There was a problem hiding this comment.
Just checking something... the PR description says it should live in packages/block-library/src/navigation-link/shared/render-submenu-icon.php.
To be clear, packages/block-library/src/navigation-submenu/index.php is fine since it was first deleted here:
There was a problem hiding this comment.
Good catch, thank you — you're right that the description was stale. I started with the shim in render-submenu-icon.php (commit 1), then moved it into navigation-submenu/index.php (commit 2) because PHPCS in the navigation-link/shared/ directory only accepts function names matching the block_core_shared* prefix. I just updated the PR description to match the code, and linked to the same L87 deletion you pointed at as the justification for the placement. Appreciate the review!
|
LGTM thanks for the quick patch @ecairol 🙇🏻 @scruffian @getdave do you think this is worth a point release? if so, we might need to coordinate with @ellatrix or someone in the release squad. |
| require_once __DIR__ . '/navigation-link/shared/render-submenu-icon.php'; | ||
| require_once __DIR__ . '/navigation-link/shared/build-css-font-sizes.php'; | ||
|
|
||
| if ( ! function_exists( 'block_core_navigation_submenu_render_submenu_icon' ) ) { |
There was a problem hiding this comment.
Wrapped in a
function_existsguard so a future Core sync that brings the shim back to Core itself doesn't double-declare.
I don't think a double declaration can occur, so we can remove this function existence check.
There was a problem hiding this comment.
Agreed. The only way that comes to mind would be if a theme/plugin declares it after seeing it doesn't exist in 7.0, but it's as rare an edge case as using the function in a theme/plugin in the first place.
| /** | ||
| * @group blocks | ||
| */ | ||
| class Block_Core_Navigation_Submenu_Render_Submenu_Icon_Test extends WP_UnitTestCase { |
There was a problem hiding this comment.
The existence test for a deprecated function felt a bit like overkill to me. Is it really necessary? I'm generally fine with regression tests, but I don't see a good need for that, unless it's actually used somewhere.
| require_once __DIR__ . '/navigation-link/shared/render-submenu-icon.php'; | ||
| require_once __DIR__ . '/navigation-link/shared/build-css-font-sizes.php'; | ||
|
|
||
| if ( ! function_exists( 'block_core_navigation_submenu_render_submenu_icon' ) ) { |
There was a problem hiding this comment.
Agreed. The only way that comes to mind would be if a theme/plugin declares it after seeing it doesn't exist in 7.0, but it's as rare an edge case as using the function in a theme/plugin in the first place.
| * Renders the submenu icon SVG for the Navigation Submenu block. | ||
| * | ||
| * @since 5.9.0 | ||
| * @deprecated 7.0.0 Use block_core_shared_navigation_render_submenu_icon() instead. |
There was a problem hiding this comment.
Just to confirm, it's intended to land in a patch version?
| * In Gutenberg plugin builds, the function name is prefixed with `gutenberg_` | ||
| * by the build system to avoid colliding with the WordPress Core version. These | ||
| * tests therefore exercise the prefixed name; the unprefixed counterpart is the | ||
| * one Core ships once the change syncs back. |
There was a problem hiding this comment.
Is this really true for this function? I see no prefixing happening with that function at all.
There was a problem hiding this comment.
Apologies. This was AI adding unnecessary comments. Apparently, there's an automatic prefixing at build that prepends gutenberg_:
The build genuinely rewrites function NAME( → function gutenberg_NAME( for everything under packages/block-library/src/**/*.php
However, the comment was pure noise, and it's been removed now (84e2c4a)
|
Added the label to backport this to the next minor WP release, as that seems like the likeliest thing that will happen. |
|
Looks like the PHP test caused a CI failure on trunk, I expect it might need to be gated by WordPress version or something. I can follow up on it. |
|
Ah, I don't think that matrix runs on PRs. I guess we could guard the test so it only runs when the shared core helper exists. I dunno. if ( ! function_exists( 'block_core_shared_navigation_render_submenu_icon' ) ) {
$this->markTestSkipped( 'block_core_shared_navigation_render_submenu_icon() is not available in this WordPress version.' );
} |
|
It should be fixed via d8688b2 |
This updates the pinned commit hash of the Gutenberg repository from `d5ac60e6118060529737127d44a6fdc8abf57eb9 ` (version `23.2.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.3.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.2.0..v23.3.0. The following commits are included: - Performance tests: fix template click, delete pages at startup (WordPress/gutenberg#78193) - [ui] Add internal wp compat overlay slot helper (WordPress/gutenberg#77851) - Build: Detect stale node_modules at build/dev time (WordPress/gutenberg#77995) - migrated __experimentalText, __experimentalHStack, and __experimentalVStack to Text and Stack (WordPress/gutenberg#78155) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - RTC: fix cursor awareness / presence bug in nested rich text elements (WordPress/gutenberg#77673) - Core Data: Share parsed blocks cache between resolver and editor hook (WordPress/gutenberg#78026) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - scripts: Fix path for license type detection in license.js (WordPress/gutenberg#78245) - Extract media editor save hook (WordPress/gutenberg#78225) - Block Library: Fix Tabs block losing added tabs when the editor is reopened (WordPress/gutenberg#78250) - Extract media editor crop options hook (WordPress/gutenberg#78263) - Media Editor Modal: Add custom datetime view for the sidebar to ensure minimal display of dates (WordPress/gutenberg#78265) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Move Layout panel into styles tab so it sits next to Dimensions (WordPress/gutenberg#77922) - Media Editor Modal: Only show the crop active state when using keyboard (WordPress/gutenberg#78266) - Add supports for pseudo states on single block instances (WordPress/gutenberg#76491) - Perf tests: Save Chromium traces as CI artifacts (WordPress/gutenberg#77974) - Media editor: show live crop dimensions during gesture (WordPress/gutenberg#78221) - Fix flaky navigation frontend submenu e2e test (WordPress/gutenberg#78270) - Widget dashboard: skip tile hover elevation while resizing (WordPress/gutenberg#78234) - DataViews: Adopt `@wordpress/theme` design tokens (WordPress/gutenberg#75204) - Home Link: Add missing controls (WordPress/gutenberg#76672) - Overlays: Extend positioner slot pattern to Popover, Select, Autocomplete (WordPress/gutenberg#78168) - Make RTC-related APIs private (WordPress/gutenberg#78097) - Block Toolbar: Prevent position shifts when using mover control (WordPress/gutenberg#77798) - Experiment: Add default term for taxonomies (WordPress/gutenberg#78233) - [ui] Tooltip: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78095) - Performance Tests: log timestamps, optimize build overhead (WordPress/gutenberg#78237) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) - Stabilize small-scope flaky e2e tests (WordPress/gutenberg#77893) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Tests: Add `timezone-mock` to `test/unit/package.json` (WordPress/gutenberg#78277) - Fix performance tests when running against old reference commit (WordPress/gutenberg#78288) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Stylelint: Add more exemptions to logical properties rules (WordPress/gutenberg#78252) - Menu: Reduce flaky Space key test scope (WordPress/gutenberg#78246) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) - Refactor validation tools and update related scripts (WordPress/gutenberg#77522) - Storybook: Add text overflow E2E stories (WordPress/gutenberg#78256) - Routes: Enforce logical CSS properties in stylesheets (WordPress/gutenberg#78291) - Migrate pattern list item titles to Text from @wordpress/ui (WordPress/gutenberg#77656) - Perf tests: Capture loading durations before stopTracing() (WordPress/gutenberg#78294) - Perf tests: Disable Playwright tracing to remove snapshot overhead (WordPress/gutenberg#78295) - Notes: Support multiple note threads per block (WordPress/gutenberg#75147) - make widget framework types generic (WordPress/gutenberg#78247) - Blocks: Ensure proper merging of classes in block schemas (WordPress/gutenberg#70615) - Collab Sidebar: Replace near-identical pink with red in avatar palette (WordPress/gutenberg#78299) - Compose: Share a single change listener per MediaQueryList in useMediaQuery (WordPress/gutenberg#78297) - Add custom widget dashboard resize handle styling. (WordPress/gutenberg#78236) - Block Editor: Integrate slug-based color selection in color panel (WordPress/gutenberg#78048) - wp-build: Replace getter-based exports with data properties (WordPress/gutenberg#78303) - RTC: Fix connection lost error modal when /wp-json/wp-sync/v1/updates exceeds 16 MiB limit (WordPress/gutenberg#77724) - Hide wrap by default in flex layout panel (WordPress/gutenberg#78269) - Prevent images from appearing squished when only one dimension is set (WordPress/gutenberg#70575) - Block Style States: Show only supported inspector controls when selecting a style state (WordPress/gutenberg#78280) - Build: Remove custom job_status output in favor of native result (WordPress/gutenberg#78208) - Improve GHCR asset publishing and expand trigger events to include `pull_request` (WordPress/gutenberg#78211) - Media Editor: Scope keyboard shortcuts to the modal (WordPress/gutenberg#78322) - Fix 'Invalid Date' when clicking on Now in DateTimePicker on Date Block. (WordPress/gutenberg#78284) - Dashboard: round widget drag radius (WordPress/gutenberg#78292) - Core Abilities: Defer fetch until workflow palette opens (WordPress/gutenberg#78316) - Manually update all package versions to match wp/latest (WordPress/gutenberg#78301) - Dashboard: layout settings drawer with grid/masonry models (WordPress/gutenberg#78202) - Components: Fix FormTokenField validation preventing default behavior (WordPress/gutenberg#77181) - Core Data: Avoid duplicate id-less entity permission requests (WordPress/gutenberg#78262) - Post/Site Editor loading test: remove unwanted actions from timed code path (WordPress/gutenberg#78323) - Tests: Add post-editor preload spec (WordPress/gutenberg#78318) - Automated Testing: Allow console logging in all bin, scripts, tools files (WordPress/gutenberg#78312) - [components] Draggable: Migrate clone wrapper to wp compat overlay slot (WordPress/gutenberg#78183) - Editor: Inline text editor toolbar z-index (WordPress/gutenberg#78309) - Automated Testing: Skip ESLint for bundled library code via ignore patterns (WordPress/gutenberg#78314) - Refactor: useMemo on elements and useCallback is back on resetAllFilter (WordPress/gutenberg#78329) - Guidelines: Fix fatal when `rest_api_init` fires before init (WordPress/gutenberg#78350) - Upload Media: stop propagating `-scaled` to sub-size filenames (WordPress/gutenberg#78038) - design-system-mcp: Update get_components to optionally support multiple names (WordPress/gutenberg#78185) - Dashboard: adds tooltip explaining disabled menu item (WordPress/gutenberg#78344) - Grid: make resize overlay line solid (WordPress/gutenberg#78340) - Dashboard: migrate Layout settings drawer to DataForm (WordPress/gutenberg#78336) - Add dimension validation to sideload endpoint (WordPress/gutenberg#74903) - Tests: Preload spec — track query strings and use an existing draft (WordPress/gutenberg#78343) - design-system-mcp: Add server instructions for client usage guidance (WordPress/gutenberg#78186) - Draggable: Scope the clone's fallback `z-index` to non-slot placements (WordPress/gutenberg#78354) - [ui] Trim verbose comments around the compat overlay slot (WordPress/gutenberg#78356) - DataViews: Inline z-index values (WordPress/gutenberg#78315) - Block/Tabs: Remove mount-time setAttributes that caused dirty editor state on reload (WordPress/gutenberg#78339) - Connectors: Consolidate WP 7.0 compat loading and move from experimental (WordPress/gutenberg#78228) - Grid: visualize columns without outline (WordPress/gutenberg#78281) - Media Editor: Harden cropper math layer against non-finite inputs (WordPress/gutenberg#78321) - Media Editor: Enforce a minimum crop size in the image editor (WordPress/gutenberg#78268) - Editor: Use _n() for revisions count aria-label (WordPress/gutenberg#78382) - Media Editor: Anchor cursorless zoom (slider/keyboard) at crop center (WordPress/gutenberg#78385) - Dashboard: layered grid columns + visual layout model picker (WordPress/gutenberg#78364) - Refactor: Add extractPresetSlug as a generalized function to extract slugs. (WordPress/gutenberg#78328) - Dashboard: full size widget inserter (WordPress/gutenberg#78390) - Grid: resize widget and snap resize-placeholder (WordPress/gutenberg#78389) - UI Card: full bleed as header hero image & content cover (WordPress/gutenberg#77856) - Modal: Inline header z-index (WordPress/gutenberg#78362) - UI Icon: Mark as recommended (WordPress/gutenberg#78365) - Use WCIcon alias for component Icon imports (WordPress/gutenberg#78366) - Tools(Release): migrate bin/plugin into @wordpress/release-tools workspace (WordPress/gutenberg#77695) - UI Button: Optimize overflow styles (WordPress/gutenberg#78300) - [ui] Select: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78372) - Grid: tiled grid overlay (WordPress/gutenberg#78373) - useCopyToClipboard: Always call onSuccess callback (WordPress/gutenberg#78387) - Remove commander.js file from the project (WordPress/gutenberg#78400) - [ui] Autocomplete: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78375) - Use WCTooltip alias for component Tooltip imports (WordPress/gutenberg#78396) - Upload Media: pick up the finalized attachment URL so srcset renders (WordPress/gutenberg#78359) - UI: Fix item popup typography (WordPress/gutenberg#78403) - RTC: Add command to run in WebSockets mode (WordPress/gutenberg#78363) - Publishing packages: defer pushing tags until lerna publish succeeds (WordPress/gutenberg#78253) - Fix: Show collaborators with top toolbar is active (WordPress/gutenberg#78049) - Image block: Add "Mark as decorative" toggle for accessibility (WordPress/gutenberg#78064) - Revisions: Use CSS outline as secondary non-color indicator for diff blocks (WordPress/gutenberg#78393) - DataViewsPicker Table: Fix first-click row selection (WordPress/gutenberg#78423) - Fixed additional issues with block registration types (WordPress/gutenberg#78416) - Media Editor: Make zoom floor coverage-aware instead of fixed at 1x (WordPress/gutenberg#78222) - Grid: animate sibling tiles when layout reflows during drag or resize (WordPress/gutenberg#78395) - Widget Types: declarative presentation hint (full-bleed support) (WordPress/gutenberg#78209) - Image: Fix missing aria-label on lightbox trigger button for single images (WordPress/gutenberg#78426) - Columns: Remove redundant Skip option from layout picker (WordPress/gutenberg#78405) - Components: Popover: don't close when focus moves into the `@wordpress/ui` compat overlay slot (WordPress/gutenberg#78407) - Script Loader: Defer single-page admin init until DOMContentLoaded (Trac WordPress/gutenberg#65103) (WordPress/gutenberg#78136) - Grid: fix immutability lint warning for react hook (WordPress/gutenberg#78431) - Tabs, TabPanel: Align styles with wp-ui (WordPress/gutenberg#78418) - List View: Place caret at end of block when selecting (WordPress/gutenberg#76797) - Dashboard: restrict widget icons to just SVGs (no dashicons) (WordPress/gutenberg#78440) - Dashboard: Increase widget spacing with --wp-grid-gap. (WordPress/gutenberg#78439) - RTC: Provide `PROTOCOL_MISMATCH` error handling (WordPress/gutenberg#76991) - Dashboard: add chrome UI tools to widgets (WordPress/gutenberg#78060) - Experiment: Update Classic block deprecation notice (WordPress/gutenberg#78445) - UI Tabs: Recommend component for use (WordPress/gutenberg#78442) - RTC: Sync the content even if its a function (WordPress/gutenberg#76796) - Theme: Move token structure descriptions into tokens document (WordPress/gutenberg#78438) - Fix persistCRDTDoc minimal save payload (WordPress/gutenberg#77050) - useDialog: handle Escape via React `onKeyDown` so cascade works through portals (WordPress/gutenberg#78433) - Fix inconsistencies in feature selector processing part 1: global styles (WordPress/gutenberg#78276) - Media: Add undo snackbar for media editor image edits (WordPress/gutenberg#78425) - Media Fields: Fix filename truncation with Tooltip (WordPress/gutenberg#78453) - Media Editor Modal: Fix unexpected tab stop on date fields in the Details sidebar (WordPress/gutenberg#78454) - Add experiment to show admin bar in Post and Site Editor (WordPress/gutenberg#77964) - Visually align `Notice` from `@wordpress/components` with `Notice` from `@wordpress/ui` (WordPress/gutenberg#78231) - Widgets: Declare dependencies in a per-widget package.json (WordPress/gutenberg#78463) - Grid: don't allow resizing tile beyond min row height or column width (WordPress/gutenberg#78402) - UI Autocomplete: Fix prop types (WordPress/gutenberg#78450) - @wordpress/ui: Compat overlay slot — viewport-sized containing block (WordPress/gutenberg#78441) - Fix image upload crashes (WordPress/gutenberg#76707) - Theme: Add Tokens "Introduction" Storybook page (WordPress/gutenberg#78449) - Blocks: Share window listeners across instances (block props, rich text, ...) (WordPress/gutenberg#78310) - UI Button: Fix disabled cursor style (WordPress/gutenberg#78479) - Add welcome dashboard widget with adaptive layout and content (WordPress/gutenberg#78461) - Responsive block instance styles (WordPress/gutenberg#78384) - REST: Guard `setAccessible()` behind PHP < 8.1 in block-editor settings controller (WordPress/gutenberg#78478) - Docs: Update iframe editor migration guide for WordPress 7.0/7.1 (WordPress/gutenberg#78401) - Fix inconsistencies in feature selector processing part 2: pseudo block instances (WordPress/gutenberg#78326) - Media Editor Experiments: Tidy up by removing old pathways to the media editor experiment (WordPress/gutenberg#78489) - Compose: Simplify subscribeDelegatedListener root detection (WordPress/gutenberg#78492) - Dashboard: use Page hasPadding prop for content spacing (WordPress/gutenberg#78469) - Grid: hide resize handles and actions while on tile is resizing (WordPress/gutenberg#78391) - Dashboard Widgets: Add content-bleed presentation variant (WordPress/gutenberg#78491) - Dashboard: forbid non-module stylesheets in experimental, new widgets (WordPress/gutenberg#78496) - Revisions: Increase diff marker stripe contrast to 75% primary color proportion (WordPress/gutenberg#78473) - Fix flaky e2e test with dataview kbd navigation (WordPress/gutenberg#78503) - Theme: Update color space registration to avoid side effects (WordPress/gutenberg#77653) - Move PHP Sync Issue Generator file to @wordpress/release-tools (WordPress/gutenberg#78456) - ESLint: Support private API component denylist (WordPress/gutenberg#78451) - Widgets: Add TypeScript project config (WordPress/gutenberg#78467) - Dashboard: small changes to header (WordPress/gutenberg#78513) - Edit post: consume preload cache before React mount (WordPress/gutenberg#78508) - Vips: Remove dead batchResizeImage and vipsBatchResizeImage exports (WordPress/gutenberg#77975) - Automated Testing: Enable concurrency for ESLint (WordPress/gutenberg#78360) - Simplify component ESLint rules and extend to routes/widgets (WordPress/gutenberg#78519) - Image editor: remove unnecessary __nextHasNoMarginBottom prop (WordPress/gutenberg#78530) - RTC: Limit CRDT meta data to REST API edit context (WordPress/gutenberg#78531). - Update plugin release docs and edit for clarity. (WordPress/gutenberg#78537) - Updated the BlockAttribute typedef to allow for multi-type attributes (WordPress/gutenberg#78517) - Refactor media editor crop state into composite reducer (WordPress/gutenberg#78480) - Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim (WordPress/gutenberg#78484) - Font Library: clarify active variant state in Library tab (WordPress/gutenberg#78501) - Guard PHP unit test to avoid failures on old wp versions (WordPress/gutenberg#78547) - Fix block preview for responsive style states (WordPress/gutenberg#78538) - Breadcrumbs block: Hide separator from screen readers (WordPress/gutenberg#78524) - Preload: Backport user global styles entry for classic themes on WP 6.9 (WordPress/gutenberg#78546) - Guidelines: Refine access policy (WordPress/gutenberg#78296) - Fix flaky media upload save lock test (WordPress/gutenberg#78544) - Add `Quick post` widget (WordPress/gutenberg#78408) - Tooltip migration: block-editor + block-directory consumers (1/5) (WordPress/gutenberg#78411) - Navigation: Hard deprecate component (WordPress/gutenberg#78529) - Post Taxonomies: Drop redundant `per_page: -1` from taxonomy queries (WordPress/gutenberg#78569) - Dashboard: add elevation to widget actionable area (WordPress/gutenberg#78563) - Add dashboard Activity widget (WordPress/gutenberg#78552) - Components: Remove deprecated `__experimentalApplyValueToSides` export (WordPress/gutenberg#78528) - IconButton: Fix `focusableWhenDisabled` default (WordPress/gutenberg#78526) - Add cherry-pick script and update release tools in package.json (WordPress/gutenberg#78560) - Theme: Remove and prevent dependency grouping comments (WordPress/gutenberg#78573) - Dashboard: per-instance widget settings drawer (WordPress/gutenberg#78465) - Dashboard Widgets: Adapt Quick Draft to its tile size with a recent drafts list (WordPress/gutenberg#78572) - Add dashboard Site Preview widget (WordPress/gutenberg#78556) - Edit Post Preload: Cover remaining bound GET/OPTIONS requests on load (WordPress/gutenberg#78565) - Several improvements to the Dependabot configuration (WordPress/gutenberg#78536) - Fix: Disable collab sync when incompatible meta boxes are present. (WordPress/gutenberg#78145) - Bump the github-actions group across 2 directories with 6 updates (WordPress/gutenberg#78585) - Editor / Block Editor: Lazy-fetch user pattern categories (WordPress/gutenberg#78568) - RTC: Fix every update block refresh when a peer edits with in the code editor (WordPress/gutenberg#78483) - Edit Post: Hoist setupEditor to run before root.render (WordPress/gutenberg#78581) - Automated Testing: Fix and use built-in mechanism for flagging unused disables (WordPress/gutenberg#78313) - Remove dependency used for counting available CPUs (WordPress/gutenberg#78593) - ESLint: Restrict deprecated __nextHasNoMarginBottom prop (WordPress/gutenberg#78579) - Reset zoom level on component unmount (WordPress/gutenberg#69087) - Add missing package file to the site preview widget (WordPress/gutenberg#78583) - Add dashboard Site Health widget (WordPress/gutenberg#78555) - fix: discard unsaved HTML block changes on cancel (WordPress/gutenberg#78580) - Global styles revisions: ensure stylebook shows revision previews (WordPress/gutenberg#78490) - Docs: Update media editor documentation (WordPress/gutenberg#78617) - RTC: Fix Edit/Join row action invisible on mobile in post list (WordPress/gutenberg#78597) - Grid: animate tile removals (WordPress/gutenberg#78542) - Paste: keep `<img>` inside `<a>` when pasting plain-text HTML (WordPress/gutenberg#78015) - Deduplicate useGlobalStyles hook code (WordPress/gutenberg#78577) - Dashboard: add command palette commands (WordPress/gutenberg#78429) - Docs: Add Workspace Development guide (WordPress/gutenberg#78615) - add default widget instances to dashboard (WordPress/gutenberg#78622) - scale widget picker preview to fill slot (WordPress/gutenberg#78602) - Welcome widget: draw the version number in the banner (WordPress/gutenberg#78611) - Classic Block: Use `get_post()` in `wp_declare_classic_block_necessary` (WordPress/gutenberg#78613) - fix widget content overflowing its grid tile (WordPress/gutenberg#78627) - Fix: Register user-defined taxonomies after user-defined post types (WordPress/gutenberg#78497) - Image: Preserve width/height when converting Classic blocks to blocks (WordPress/gutenberg#78610) - Dashboard: mobile improvements (WordPress/gutenberg#78522) - Grid & Dashboard: polish dashboard drag preview motion, elevation, and drop exit (WordPress/gutenberg#78348) - Welcome widget: add a subtle shine to the version digits (WordPress/gutenberg#78626) - WP Editor Meta Box e2e: wait for TinyMCE init (WordPress/gutenberg#78631) - Quick Draft widget: layout, empty state, and style refinements (WordPress/gutenberg#78601) - Dashboard: Refine widget actionable area toolbar styling (WordPress/gutenberg#78578) - Components: Add Badge text overflow e2e story (WordPress/gutenberg#78589) - UI: Update Autocomplete clear disabled state (WordPress/gutenberg#78520) - Dashboard: tune default grid settings and starter layout (WordPress/gutenberg#78633) - RangeControl: Remove erroneous `icon` prop from web types (WordPress/gutenberg#78444) - UI: Add Button variant states e2e story (WordPress/gutenberg#78634) - DataViews: Fix wrapper height resolution in flex layouts (WordPress/gutenberg#76945) - Tooltip migration: editor + edit-post + edit-site consumers (2/5) (WordPress/gutenberg#78466) - Add dashboard News widget (WordPress/gutenberg#78554) - Add support for layout responsive styles (WordPress/gutenberg#78543) - Build Tools: Move build scripts to `@wordpress/build-scripts` workspace package (WordPress/gutenberg#78509) - Dashboard: fix widget rendering on the masonry grid (WordPress/gutenberg#78645) - Tooltip migration: dataviews consumers (3/5) (WordPress/gutenberg#78470) - Upgrade to React 19 (WordPress/gutenberg#61521) - Dashboard: use fully-specified fast-deep-equal import (WordPress/gutenberg#78660) - Hide block variation selector when style state is selected (WordPress/gutenberg#78658) - Migrate `create-test-block.sh` to `@wordpress/validation-tools` workspace (WordPress/gutenberg#78665) - Docs: Mark React Native mobile editor as unmaintained on trunk after React 19 upgrade (WordPress/gutenberg#78673) - Dashboard: URL bar in site preview widget (WordPress/gutenberg#78656) - UI Button: Fix pressed disabled styles for neutral minimal (WordPress/gutenberg#78635) - Dashboard: prevent pointer events in widget selection (WordPress/gutenberg#78681) - Block Inserter: Animate inserter button icon to signal open state. (WordPress/gutenberg#78306) - Guidelines: Add data-slug attribute to settings list items (WordPress/gutenberg#78676) - Validate additional CSS on mount (WordPress/gutenberg#78682) - Move @emotion deps out of root package.json (WordPress/gutenberg#78687) - Media Editor Modal: Tighten labels for crop handles toggle (WordPress/gutenberg#78703) - Media Editor: make the modal the default crop experience (WordPress/gutenberg#78653) - Media Editor Modal: Update the rotation ruler to use a vertical line marker (WordPress/gutenberg#78704) - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Update browserslist (WordPress/gutenberg#78840) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65560. git-svn-id: https://develop.svn.wordpress.org/trunk@62583 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `d5ac60e6118060529737127d44a6fdc8abf57eb9 ` (version `23.2.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.3.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.2.0..v23.3.0. The following commits are included: - Performance tests: fix template click, delete pages at startup (WordPress/gutenberg#78193) - [ui] Add internal wp compat overlay slot helper (WordPress/gutenberg#77851) - Build: Detect stale node_modules at build/dev time (WordPress/gutenberg#77995) - migrated __experimentalText, __experimentalHStack, and __experimentalVStack to Text and Stack (WordPress/gutenberg#78155) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - RTC: fix cursor awareness / presence bug in nested rich text elements (WordPress/gutenberg#77673) - Core Data: Share parsed blocks cache between resolver and editor hook (WordPress/gutenberg#78026) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - scripts: Fix path for license type detection in license.js (WordPress/gutenberg#78245) - Extract media editor save hook (WordPress/gutenberg#78225) - Block Library: Fix Tabs block losing added tabs when the editor is reopened (WordPress/gutenberg#78250) - Extract media editor crop options hook (WordPress/gutenberg#78263) - Media Editor Modal: Add custom datetime view for the sidebar to ensure minimal display of dates (WordPress/gutenberg#78265) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Move Layout panel into styles tab so it sits next to Dimensions (WordPress/gutenberg#77922) - Media Editor Modal: Only show the crop active state when using keyboard (WordPress/gutenberg#78266) - Add supports for pseudo states on single block instances (WordPress/gutenberg#76491) - Perf tests: Save Chromium traces as CI artifacts (WordPress/gutenberg#77974) - Media editor: show live crop dimensions during gesture (WordPress/gutenberg#78221) - Fix flaky navigation frontend submenu e2e test (WordPress/gutenberg#78270) - Widget dashboard: skip tile hover elevation while resizing (WordPress/gutenberg#78234) - DataViews: Adopt `@wordpress/theme` design tokens (WordPress/gutenberg#75204) - Home Link: Add missing controls (WordPress/gutenberg#76672) - Overlays: Extend positioner slot pattern to Popover, Select, Autocomplete (WordPress/gutenberg#78168) - Make RTC-related APIs private (WordPress/gutenberg#78097) - Block Toolbar: Prevent position shifts when using mover control (WordPress/gutenberg#77798) - Experiment: Add default term for taxonomies (WordPress/gutenberg#78233) - [ui] Tooltip: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78095) - Performance Tests: log timestamps, optimize build overhead (WordPress/gutenberg#78237) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) - Stabilize small-scope flaky e2e tests (WordPress/gutenberg#77893) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Tests: Add `timezone-mock` to `test/unit/package.json` (WordPress/gutenberg#78277) - Fix performance tests when running against old reference commit (WordPress/gutenberg#78288) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Stylelint: Add more exemptions to logical properties rules (WordPress/gutenberg#78252) - Menu: Reduce flaky Space key test scope (WordPress/gutenberg#78246) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) - Refactor validation tools and update related scripts (WordPress/gutenberg#77522) - Storybook: Add text overflow E2E stories (WordPress/gutenberg#78256) - Routes: Enforce logical CSS properties in stylesheets (WordPress/gutenberg#78291) - Migrate pattern list item titles to Text from @wordpress/ui (WordPress/gutenberg#77656) - Perf tests: Capture loading durations before stopTracing() (WordPress/gutenberg#78294) - Perf tests: Disable Playwright tracing to remove snapshot overhead (WordPress/gutenberg#78295) - Notes: Support multiple note threads per block (WordPress/gutenberg#75147) - make widget framework types generic (WordPress/gutenberg#78247) - Blocks: Ensure proper merging of classes in block schemas (WordPress/gutenberg#70615) - Collab Sidebar: Replace near-identical pink with red in avatar palette (WordPress/gutenberg#78299) - Compose: Share a single change listener per MediaQueryList in useMediaQuery (WordPress/gutenberg#78297) - Add custom widget dashboard resize handle styling. (WordPress/gutenberg#78236) - Block Editor: Integrate slug-based color selection in color panel (WordPress/gutenberg#78048) - wp-build: Replace getter-based exports with data properties (WordPress/gutenberg#78303) - RTC: Fix connection lost error modal when /wp-json/wp-sync/v1/updates exceeds 16 MiB limit (WordPress/gutenberg#77724) - Hide wrap by default in flex layout panel (WordPress/gutenberg#78269) - Prevent images from appearing squished when only one dimension is set (WordPress/gutenberg#70575) - Block Style States: Show only supported inspector controls when selecting a style state (WordPress/gutenberg#78280) - Build: Remove custom job_status output in favor of native result (WordPress/gutenberg#78208) - Improve GHCR asset publishing and expand trigger events to include `pull_request` (WordPress/gutenberg#78211) - Media Editor: Scope keyboard shortcuts to the modal (WordPress/gutenberg#78322) - Fix 'Invalid Date' when clicking on Now in DateTimePicker on Date Block. (WordPress/gutenberg#78284) - Dashboard: round widget drag radius (WordPress/gutenberg#78292) - Core Abilities: Defer fetch until workflow palette opens (WordPress/gutenberg#78316) - Manually update all package versions to match wp/latest (WordPress/gutenberg#78301) - Dashboard: layout settings drawer with grid/masonry models (WordPress/gutenberg#78202) - Components: Fix FormTokenField validation preventing default behavior (WordPress/gutenberg#77181) - Core Data: Avoid duplicate id-less entity permission requests (WordPress/gutenberg#78262) - Post/Site Editor loading test: remove unwanted actions from timed code path (WordPress/gutenberg#78323) - Tests: Add post-editor preload spec (WordPress/gutenberg#78318) - Automated Testing: Allow console logging in all bin, scripts, tools files (WordPress/gutenberg#78312) - [components] Draggable: Migrate clone wrapper to wp compat overlay slot (WordPress/gutenberg#78183) - Editor: Inline text editor toolbar z-index (WordPress/gutenberg#78309) - Automated Testing: Skip ESLint for bundled library code via ignore patterns (WordPress/gutenberg#78314) - Refactor: useMemo on elements and useCallback is back on resetAllFilter (WordPress/gutenberg#78329) - Guidelines: Fix fatal when `rest_api_init` fires before init (WordPress/gutenberg#78350) - Upload Media: stop propagating `-scaled` to sub-size filenames (WordPress/gutenberg#78038) - design-system-mcp: Update get_components to optionally support multiple names (WordPress/gutenberg#78185) - Dashboard: adds tooltip explaining disabled menu item (WordPress/gutenberg#78344) - Grid: make resize overlay line solid (WordPress/gutenberg#78340) - Dashboard: migrate Layout settings drawer to DataForm (WordPress/gutenberg#78336) - Add dimension validation to sideload endpoint (WordPress/gutenberg#74903) - Tests: Preload spec — track query strings and use an existing draft (WordPress/gutenberg#78343) - design-system-mcp: Add server instructions for client usage guidance (WordPress/gutenberg#78186) - Draggable: Scope the clone's fallback `z-index` to non-slot placements (WordPress/gutenberg#78354) - [ui] Trim verbose comments around the compat overlay slot (WordPress/gutenberg#78356) - DataViews: Inline z-index values (WordPress/gutenberg#78315) - Block/Tabs: Remove mount-time setAttributes that caused dirty editor state on reload (WordPress/gutenberg#78339) - Connectors: Consolidate WP 7.0 compat loading and move from experimental (WordPress/gutenberg#78228) - Grid: visualize columns without outline (WordPress/gutenberg#78281) - Media Editor: Harden cropper math layer against non-finite inputs (WordPress/gutenberg#78321) - Media Editor: Enforce a minimum crop size in the image editor (WordPress/gutenberg#78268) - Editor: Use _n() for revisions count aria-label (WordPress/gutenberg#78382) - Media Editor: Anchor cursorless zoom (slider/keyboard) at crop center (WordPress/gutenberg#78385) - Dashboard: layered grid columns + visual layout model picker (WordPress/gutenberg#78364) - Refactor: Add extractPresetSlug as a generalized function to extract slugs. (WordPress/gutenberg#78328) - Dashboard: full size widget inserter (WordPress/gutenberg#78390) - Grid: resize widget and snap resize-placeholder (WordPress/gutenberg#78389) - UI Card: full bleed as header hero image & content cover (WordPress/gutenberg#77856) - Modal: Inline header z-index (WordPress/gutenberg#78362) - UI Icon: Mark as recommended (WordPress/gutenberg#78365) - Use WCIcon alias for component Icon imports (WordPress/gutenberg#78366) - Tools(Release): migrate bin/plugin into @wordpress/release-tools workspace (WordPress/gutenberg#77695) - UI Button: Optimize overflow styles (WordPress/gutenberg#78300) - [ui] Select: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78372) - Grid: tiled grid overlay (WordPress/gutenberg#78373) - useCopyToClipboard: Always call onSuccess callback (WordPress/gutenberg#78387) - Remove commander.js file from the project (WordPress/gutenberg#78400) - [ui] Autocomplete: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78375) - Use WCTooltip alias for component Tooltip imports (WordPress/gutenberg#78396) - Upload Media: pick up the finalized attachment URL so srcset renders (WordPress/gutenberg#78359) - UI: Fix item popup typography (WordPress/gutenberg#78403) - RTC: Add command to run in WebSockets mode (WordPress/gutenberg#78363) - Publishing packages: defer pushing tags until lerna publish succeeds (WordPress/gutenberg#78253) - Fix: Show collaborators with top toolbar is active (WordPress/gutenberg#78049) - Image block: Add "Mark as decorative" toggle for accessibility (WordPress/gutenberg#78064) - Revisions: Use CSS outline as secondary non-color indicator for diff blocks (WordPress/gutenberg#78393) - DataViewsPicker Table: Fix first-click row selection (WordPress/gutenberg#78423) - Fixed additional issues with block registration types (WordPress/gutenberg#78416) - Media Editor: Make zoom floor coverage-aware instead of fixed at 1x (WordPress/gutenberg#78222) - Grid: animate sibling tiles when layout reflows during drag or resize (WordPress/gutenberg#78395) - Widget Types: declarative presentation hint (full-bleed support) (WordPress/gutenberg#78209) - Image: Fix missing aria-label on lightbox trigger button for single images (WordPress/gutenberg#78426) - Columns: Remove redundant Skip option from layout picker (WordPress/gutenberg#78405) - Components: Popover: don't close when focus moves into the `@wordpress/ui` compat overlay slot (WordPress/gutenberg#78407) - Script Loader: Defer single-page admin init until DOMContentLoaded (Trac WordPress/gutenberg#65103) (WordPress/gutenberg#78136) - Grid: fix immutability lint warning for react hook (WordPress/gutenberg#78431) - Tabs, TabPanel: Align styles with wp-ui (WordPress/gutenberg#78418) - List View: Place caret at end of block when selecting (WordPress/gutenberg#76797) - Dashboard: restrict widget icons to just SVGs (no dashicons) (WordPress/gutenberg#78440) - Dashboard: Increase widget spacing with --wp-grid-gap. (WordPress/gutenberg#78439) - RTC: Provide `PROTOCOL_MISMATCH` error handling (WordPress/gutenberg#76991) - Dashboard: add chrome UI tools to widgets (WordPress/gutenberg#78060) - Experiment: Update Classic block deprecation notice (WordPress/gutenberg#78445) - UI Tabs: Recommend component for use (WordPress/gutenberg#78442) - RTC: Sync the content even if its a function (WordPress/gutenberg#76796) - Theme: Move token structure descriptions into tokens document (WordPress/gutenberg#78438) - Fix persistCRDTDoc minimal save payload (WordPress/gutenberg#77050) - useDialog: handle Escape via React `onKeyDown` so cascade works through portals (WordPress/gutenberg#78433) - Fix inconsistencies in feature selector processing part 1: global styles (WordPress/gutenberg#78276) - Media: Add undo snackbar for media editor image edits (WordPress/gutenberg#78425) - Media Fields: Fix filename truncation with Tooltip (WordPress/gutenberg#78453) - Media Editor Modal: Fix unexpected tab stop on date fields in the Details sidebar (WordPress/gutenberg#78454) - Add experiment to show admin bar in Post and Site Editor (WordPress/gutenberg#77964) - Visually align `Notice` from `@wordpress/components` with `Notice` from `@wordpress/ui` (WordPress/gutenberg#78231) - Widgets: Declare dependencies in a per-widget package.json (WordPress/gutenberg#78463) - Grid: don't allow resizing tile beyond min row height or column width (WordPress/gutenberg#78402) - UI Autocomplete: Fix prop types (WordPress/gutenberg#78450) - @wordpress/ui: Compat overlay slot — viewport-sized containing block (WordPress/gutenberg#78441) - Fix image upload crashes (WordPress/gutenberg#76707) - Theme: Add Tokens "Introduction" Storybook page (WordPress/gutenberg#78449) - Blocks: Share window listeners across instances (block props, rich text, ...) (WordPress/gutenberg#78310) - UI Button: Fix disabled cursor style (WordPress/gutenberg#78479) - Add welcome dashboard widget with adaptive layout and content (WordPress/gutenberg#78461) - Responsive block instance styles (WordPress/gutenberg#78384) - REST: Guard `setAccessible()` behind PHP < 8.1 in block-editor settings controller (WordPress/gutenberg#78478) - Docs: Update iframe editor migration guide for WordPress 7.0/7.1 (WordPress/gutenberg#78401) - Fix inconsistencies in feature selector processing part 2: pseudo block instances (WordPress/gutenberg#78326) - Media Editor Experiments: Tidy up by removing old pathways to the media editor experiment (WordPress/gutenberg#78489) - Compose: Simplify subscribeDelegatedListener root detection (WordPress/gutenberg#78492) - Dashboard: use Page hasPadding prop for content spacing (WordPress/gutenberg#78469) - Grid: hide resize handles and actions while on tile is resizing (WordPress/gutenberg#78391) - Dashboard Widgets: Add content-bleed presentation variant (WordPress/gutenberg#78491) - Dashboard: forbid non-module stylesheets in experimental, new widgets (WordPress/gutenberg#78496) - Revisions: Increase diff marker stripe contrast to 75% primary color proportion (WordPress/gutenberg#78473) - Fix flaky e2e test with dataview kbd navigation (WordPress/gutenberg#78503) - Theme: Update color space registration to avoid side effects (WordPress/gutenberg#77653) - Move PHP Sync Issue Generator file to @wordpress/release-tools (WordPress/gutenberg#78456) - ESLint: Support private API component denylist (WordPress/gutenberg#78451) - Widgets: Add TypeScript project config (WordPress/gutenberg#78467) - Dashboard: small changes to header (WordPress/gutenberg#78513) - Edit post: consume preload cache before React mount (WordPress/gutenberg#78508) - Vips: Remove dead batchResizeImage and vipsBatchResizeImage exports (WordPress/gutenberg#77975) - Automated Testing: Enable concurrency for ESLint (WordPress/gutenberg#78360) - Simplify component ESLint rules and extend to routes/widgets (WordPress/gutenberg#78519) - Image editor: remove unnecessary __nextHasNoMarginBottom prop (WordPress/gutenberg#78530) - RTC: Limit CRDT meta data to REST API edit context (WordPress/gutenberg#78531). - Update plugin release docs and edit for clarity. (WordPress/gutenberg#78537) - Updated the BlockAttribute typedef to allow for multi-type attributes (WordPress/gutenberg#78517) - Refactor media editor crop state into composite reducer (WordPress/gutenberg#78480) - Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim (WordPress/gutenberg#78484) - Font Library: clarify active variant state in Library tab (WordPress/gutenberg#78501) - Guard PHP unit test to avoid failures on old wp versions (WordPress/gutenberg#78547) - Fix block preview for responsive style states (WordPress/gutenberg#78538) - Breadcrumbs block: Hide separator from screen readers (WordPress/gutenberg#78524) - Preload: Backport user global styles entry for classic themes on WP 6.9 (WordPress/gutenberg#78546) - Guidelines: Refine access policy (WordPress/gutenberg#78296) - Fix flaky media upload save lock test (WordPress/gutenberg#78544) - Add `Quick post` widget (WordPress/gutenberg#78408) - Tooltip migration: block-editor + block-directory consumers (1/5) (WordPress/gutenberg#78411) - Navigation: Hard deprecate component (WordPress/gutenberg#78529) - Post Taxonomies: Drop redundant `per_page: -1` from taxonomy queries (WordPress/gutenberg#78569) - Dashboard: add elevation to widget actionable area (WordPress/gutenberg#78563) - Add dashboard Activity widget (WordPress/gutenberg#78552) - Components: Remove deprecated `__experimentalApplyValueToSides` export (WordPress/gutenberg#78528) - IconButton: Fix `focusableWhenDisabled` default (WordPress/gutenberg#78526) - Add cherry-pick script and update release tools in package.json (WordPress/gutenberg#78560) - Theme: Remove and prevent dependency grouping comments (WordPress/gutenberg#78573) - Dashboard: per-instance widget settings drawer (WordPress/gutenberg#78465) - Dashboard Widgets: Adapt Quick Draft to its tile size with a recent drafts list (WordPress/gutenberg#78572) - Add dashboard Site Preview widget (WordPress/gutenberg#78556) - Edit Post Preload: Cover remaining bound GET/OPTIONS requests on load (WordPress/gutenberg#78565) - Several improvements to the Dependabot configuration (WordPress/gutenberg#78536) - Fix: Disable collab sync when incompatible meta boxes are present. (WordPress/gutenberg#78145) - Bump the github-actions group across 2 directories with 6 updates (WordPress/gutenberg#78585) - Editor / Block Editor: Lazy-fetch user pattern categories (WordPress/gutenberg#78568) - RTC: Fix every update block refresh when a peer edits with in the code editor (WordPress/gutenberg#78483) - Edit Post: Hoist setupEditor to run before root.render (WordPress/gutenberg#78581) - Automated Testing: Fix and use built-in mechanism for flagging unused disables (WordPress/gutenberg#78313) - Remove dependency used for counting available CPUs (WordPress/gutenberg#78593) - ESLint: Restrict deprecated __nextHasNoMarginBottom prop (WordPress/gutenberg#78579) - Reset zoom level on component unmount (WordPress/gutenberg#69087) - Add missing package file to the site preview widget (WordPress/gutenberg#78583) - Add dashboard Site Health widget (WordPress/gutenberg#78555) - fix: discard unsaved HTML block changes on cancel (WordPress/gutenberg#78580) - Global styles revisions: ensure stylebook shows revision previews (WordPress/gutenberg#78490) - Docs: Update media editor documentation (WordPress/gutenberg#78617) - RTC: Fix Edit/Join row action invisible on mobile in post list (WordPress/gutenberg#78597) - Grid: animate tile removals (WordPress/gutenberg#78542) - Paste: keep `<img>` inside `<a>` when pasting plain-text HTML (WordPress/gutenberg#78015) - Deduplicate useGlobalStyles hook code (WordPress/gutenberg#78577) - Dashboard: add command palette commands (WordPress/gutenberg#78429) - Docs: Add Workspace Development guide (WordPress/gutenberg#78615) - add default widget instances to dashboard (WordPress/gutenberg#78622) - scale widget picker preview to fill slot (WordPress/gutenberg#78602) - Welcome widget: draw the version number in the banner (WordPress/gutenberg#78611) - Classic Block: Use `get_post()` in `wp_declare_classic_block_necessary` (WordPress/gutenberg#78613) - fix widget content overflowing its grid tile (WordPress/gutenberg#78627) - Fix: Register user-defined taxonomies after user-defined post types (WordPress/gutenberg#78497) - Image: Preserve width/height when converting Classic blocks to blocks (WordPress/gutenberg#78610) - Dashboard: mobile improvements (WordPress/gutenberg#78522) - Grid & Dashboard: polish dashboard drag preview motion, elevation, and drop exit (WordPress/gutenberg#78348) - Welcome widget: add a subtle shine to the version digits (WordPress/gutenberg#78626) - WP Editor Meta Box e2e: wait for TinyMCE init (WordPress/gutenberg#78631) - Quick Draft widget: layout, empty state, and style refinements (WordPress/gutenberg#78601) - Dashboard: Refine widget actionable area toolbar styling (WordPress/gutenberg#78578) - Components: Add Badge text overflow e2e story (WordPress/gutenberg#78589) - UI: Update Autocomplete clear disabled state (WordPress/gutenberg#78520) - Dashboard: tune default grid settings and starter layout (WordPress/gutenberg#78633) - RangeControl: Remove erroneous `icon` prop from web types (WordPress/gutenberg#78444) - UI: Add Button variant states e2e story (WordPress/gutenberg#78634) - DataViews: Fix wrapper height resolution in flex layouts (WordPress/gutenberg#76945) - Tooltip migration: editor + edit-post + edit-site consumers (2/5) (WordPress/gutenberg#78466) - Add dashboard News widget (WordPress/gutenberg#78554) - Add support for layout responsive styles (WordPress/gutenberg#78543) - Build Tools: Move build scripts to `@wordpress/build-scripts` workspace package (WordPress/gutenberg#78509) - Dashboard: fix widget rendering on the masonry grid (WordPress/gutenberg#78645) - Tooltip migration: dataviews consumers (3/5) (WordPress/gutenberg#78470) - Upgrade to React 19 (WordPress/gutenberg#61521) - Dashboard: use fully-specified fast-deep-equal import (WordPress/gutenberg#78660) - Hide block variation selector when style state is selected (WordPress/gutenberg#78658) - Migrate `create-test-block.sh` to `@wordpress/validation-tools` workspace (WordPress/gutenberg#78665) - Docs: Mark React Native mobile editor as unmaintained on trunk after React 19 upgrade (WordPress/gutenberg#78673) - Dashboard: URL bar in site preview widget (WordPress/gutenberg#78656) - UI Button: Fix pressed disabled styles for neutral minimal (WordPress/gutenberg#78635) - Dashboard: prevent pointer events in widget selection (WordPress/gutenberg#78681) - Block Inserter: Animate inserter button icon to signal open state. (WordPress/gutenberg#78306) - Guidelines: Add data-slug attribute to settings list items (WordPress/gutenberg#78676) - Validate additional CSS on mount (WordPress/gutenberg#78682) - Move @emotion deps out of root package.json (WordPress/gutenberg#78687) - Media Editor Modal: Tighten labels for crop handles toggle (WordPress/gutenberg#78703) - Media Editor: make the modal the default crop experience (WordPress/gutenberg#78653) - Media Editor Modal: Update the rotation ruler to use a vertical line marker (WordPress/gutenberg#78704) - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Update browserslist (WordPress/gutenberg#78840) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65560. Built from https://develop.svn.wordpress.org/trunk@62583 git-svn-id: http://core.svn.wordpress.org/trunk@61863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
…() as deprecated shim (#78484) * Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim In #74853 the function was removed from packages/block-library/src/navigation-submenu/index.php without a _deprecated_function() notice. Once that change synced into Core (wordpress-develop #10865, scheduled for WP 7.0), themes and plugins that called the function — for example from a render_block_core/navigation-submenu filter — started fatal-erroring. This restores it as a thin wrapper that triggers _deprecated_function() and returns block_core_shared_navigation_render_submenu_icon(), the new shared helper that replaced it. Adding it to the shared file means it's available wherever the original was previously rendered. A phpunit test asserts the deprecation notice fires and the return value matches the new helper. Trac ticket: https://core.trac.wordpress.org/ticket/65287 * Move shim into navigation-submenu/index.php; fix test require PHPCS in packages/block-library/src/navigation-link/shared/ enforces a function-name prefix of block_core_shared*, which forbids the deprecation shim's name. Move the shim into navigation-submenu/index.php (where the function originally lived and block_core_navigation_submenu_* is allowed), guarded by function_exists so a future Core sync that brings the shim back into Core doesn't double-declare. Drop the require_once in the test — its path resolution differed from the plugin's own init load and was triggering "Cannot redeclare" fatals against the already-loaded block_core_shared_navigation_render_submenu_icon(). Normal plugin boot loads navigation-submenu/index.php during block registration, so the shim is available to the test without an explicit require. * Use gutenberg_ prefixed function name in test The build prefixes packages/block-library functions with gutenberg_ before the plugin loads them, so in the plugin test env the shim exists as gutenberg_block_core_navigation_submenu_render_submenu_icon, not the unprefixed Core name. Match the existing block-navigation-link-variations test convention of asserting on the prefixed name with setExpectedDeprecated(). * Address review feedback: drop function_exists guard and existence test ---- Co-authored-by: ecairol <[email protected]> Co-authored-by: ramonjd <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: aaronjorbin <[email protected]> Co-authored-by: talldan <[email protected]>
|
I just cherry-picked this PR to the wp/7.0 branch to get it included in the next release: 55050d2 |
This updates the pinned commit hash of the Gutenberg repository from `d5ac60e6118060529737127d44a6fdc8abf57eb9 ` (version `23.2.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.3.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.2.0..v23.3.0. The following commits are included: - Performance tests: fix template click, delete pages at startup (WordPress/gutenberg#78193) - [ui] Add internal wp compat overlay slot helper (WordPress/gutenberg#77851) - Build: Detect stale node_modules at build/dev time (WordPress/gutenberg#77995) - migrated __experimentalText, __experimentalHStack, and __experimentalVStack to Text and Stack (WordPress/gutenberg#78155) - Connectors: Restyle AI plugin callout with pastel background and beaker decoration (WordPress/gutenberg#78243) - RTC: fix cursor awareness / presence bug in nested rich text elements (WordPress/gutenberg#77673) - Core Data: Share parsed blocks cache between resolver and editor hook (WordPress/gutenberg#78026) - Block supports: Optimize custom CSS class rendering and parsing (WordPress/gutenberg#78217) - scripts: Fix path for license type detection in license.js (WordPress/gutenberg#78245) - Extract media editor save hook (WordPress/gutenberg#78225) - Block Library: Fix Tabs block losing added tabs when the editor is reopened (WordPress/gutenberg#78250) - Extract media editor crop options hook (WordPress/gutenberg#78263) - Media Editor Modal: Add custom datetime view for the sidebar to ensure minimal display of dates (WordPress/gutenberg#78265) - Block Inspector: Hide Styles tab in preview mode (WordPress/gutenberg#78230) - Move Layout panel into styles tab so it sits next to Dimensions (WordPress/gutenberg#77922) - Media Editor Modal: Only show the crop active state when using keyboard (WordPress/gutenberg#78266) - Add supports for pseudo states on single block instances (WordPress/gutenberg#76491) - Perf tests: Save Chromium traces as CI artifacts (WordPress/gutenberg#77974) - Media editor: show live crop dimensions during gesture (WordPress/gutenberg#78221) - Fix flaky navigation frontend submenu e2e test (WordPress/gutenberg#78270) - Widget dashboard: skip tile hover elevation while resizing (WordPress/gutenberg#78234) - DataViews: Adopt `@wordpress/theme` design tokens (WordPress/gutenberg#75204) - Home Link: Add missing controls (WordPress/gutenberg#76672) - Overlays: Extend positioner slot pattern to Popover, Select, Autocomplete (WordPress/gutenberg#78168) - Make RTC-related APIs private (WordPress/gutenberg#78097) - Block Toolbar: Prevent position shifts when using mover control (WordPress/gutenberg#77798) - Experiment: Add default term for taxonomies (WordPress/gutenberg#78233) - [ui] Tooltip: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78095) - Performance Tests: log timestamps, optimize build overhead (WordPress/gutenberg#78237) - Editor: Disable Visual Revisions when classic meta boxes are present (WordPress/gutenberg#78249) - Stabilize small-scope flaky e2e tests (WordPress/gutenberg#77893) - Navigation Link: Preserve custom labels during link updates (WordPress/gutenberg#77186) - Tests: Add `timezone-mock` to `test/unit/package.json` (WordPress/gutenberg#78277) - Fix performance tests when running against old reference commit (WordPress/gutenberg#78288) - Editor: Fix Visual Revisions meta keys overlap (WordPress/gutenberg#78156) - Stylelint: Add more exemptions to logical properties rules (WordPress/gutenberg#78252) - Menu: Reduce flaky Space key test scope (WordPress/gutenberg#78246) - Revisions: Scale diff markers width with user text-size preference (WordPress/gutenberg#78273) - Refactor validation tools and update related scripts (WordPress/gutenberg#77522) - Storybook: Add text overflow E2E stories (WordPress/gutenberg#78256) - Routes: Enforce logical CSS properties in stylesheets (WordPress/gutenberg#78291) - Migrate pattern list item titles to Text from @wordpress/ui (WordPress/gutenberg#77656) - Perf tests: Capture loading durations before stopTracing() (WordPress/gutenberg#78294) - Perf tests: Disable Playwright tracing to remove snapshot overhead (WordPress/gutenberg#78295) - Notes: Support multiple note threads per block (WordPress/gutenberg#75147) - make widget framework types generic (WordPress/gutenberg#78247) - Blocks: Ensure proper merging of classes in block schemas (WordPress/gutenberg#70615) - Collab Sidebar: Replace near-identical pink with red in avatar palette (WordPress/gutenberg#78299) - Compose: Share a single change listener per MediaQueryList in useMediaQuery (WordPress/gutenberg#78297) - Add custom widget dashboard resize handle styling. (WordPress/gutenberg#78236) - Block Editor: Integrate slug-based color selection in color panel (WordPress/gutenberg#78048) - wp-build: Replace getter-based exports with data properties (WordPress/gutenberg#78303) - RTC: Fix connection lost error modal when /wp-json/wp-sync/v1/updates exceeds 16 MiB limit (WordPress/gutenberg#77724) - Hide wrap by default in flex layout panel (WordPress/gutenberg#78269) - Prevent images from appearing squished when only one dimension is set (WordPress/gutenberg#70575) - Block Style States: Show only supported inspector controls when selecting a style state (WordPress/gutenberg#78280) - Build: Remove custom job_status output in favor of native result (WordPress/gutenberg#78208) - Improve GHCR asset publishing and expand trigger events to include `pull_request` (WordPress/gutenberg#78211) - Media Editor: Scope keyboard shortcuts to the modal (WordPress/gutenberg#78322) - Fix 'Invalid Date' when clicking on Now in DateTimePicker on Date Block. (WordPress/gutenberg#78284) - Dashboard: round widget drag radius (WordPress/gutenberg#78292) - Core Abilities: Defer fetch until workflow palette opens (WordPress/gutenberg#78316) - Manually update all package versions to match wp/latest (WordPress/gutenberg#78301) - Dashboard: layout settings drawer with grid/masonry models (WordPress/gutenberg#78202) - Components: Fix FormTokenField validation preventing default behavior (WordPress/gutenberg#77181) - Core Data: Avoid duplicate id-less entity permission requests (WordPress/gutenberg#78262) - Post/Site Editor loading test: remove unwanted actions from timed code path (WordPress/gutenberg#78323) - Tests: Add post-editor preload spec (WordPress/gutenberg#78318) - Automated Testing: Allow console logging in all bin, scripts, tools files (WordPress/gutenberg#78312) - [components] Draggable: Migrate clone wrapper to wp compat overlay slot (WordPress/gutenberg#78183) - Editor: Inline text editor toolbar z-index (WordPress/gutenberg#78309) - Automated Testing: Skip ESLint for bundled library code via ignore patterns (WordPress/gutenberg#78314) - Refactor: useMemo on elements and useCallback is back on resetAllFilter (WordPress/gutenberg#78329) - Guidelines: Fix fatal when `rest_api_init` fires before init (WordPress/gutenberg#78350) - Upload Media: stop propagating `-scaled` to sub-size filenames (WordPress/gutenberg#78038) - design-system-mcp: Update get_components to optionally support multiple names (WordPress/gutenberg#78185) - Dashboard: adds tooltip explaining disabled menu item (WordPress/gutenberg#78344) - Grid: make resize overlay line solid (WordPress/gutenberg#78340) - Dashboard: migrate Layout settings drawer to DataForm (WordPress/gutenberg#78336) - Add dimension validation to sideload endpoint (WordPress/gutenberg#74903) - Tests: Preload spec — track query strings and use an existing draft (WordPress/gutenberg#78343) - design-system-mcp: Add server instructions for client usage guidance (WordPress/gutenberg#78186) - Draggable: Scope the clone's fallback `z-index` to non-slot placements (WordPress/gutenberg#78354) - [ui] Trim verbose comments around the compat overlay slot (WordPress/gutenberg#78356) - DataViews: Inline z-index values (WordPress/gutenberg#78315) - Block/Tabs: Remove mount-time setAttributes that caused dirty editor state on reload (WordPress/gutenberg#78339) - Connectors: Consolidate WP 7.0 compat loading and move from experimental (WordPress/gutenberg#78228) - Grid: visualize columns without outline (WordPress/gutenberg#78281) - Media Editor: Harden cropper math layer against non-finite inputs (WordPress/gutenberg#78321) - Media Editor: Enforce a minimum crop size in the image editor (WordPress/gutenberg#78268) - Editor: Use _n() for revisions count aria-label (WordPress/gutenberg#78382) - Media Editor: Anchor cursorless zoom (slider/keyboard) at crop center (WordPress/gutenberg#78385) - Dashboard: layered grid columns + visual layout model picker (WordPress/gutenberg#78364) - Refactor: Add extractPresetSlug as a generalized function to extract slugs. (WordPress/gutenberg#78328) - Dashboard: full size widget inserter (WordPress/gutenberg#78390) - Grid: resize widget and snap resize-placeholder (WordPress/gutenberg#78389) - UI Card: full bleed as header hero image & content cover (WordPress/gutenberg#77856) - Modal: Inline header z-index (WordPress/gutenberg#78362) - UI Icon: Mark as recommended (WordPress/gutenberg#78365) - Use WCIcon alias for component Icon imports (WordPress/gutenberg#78366) - Tools(Release): migrate bin/plugin into @wordpress/release-tools workspace (WordPress/gutenberg#77695) - UI Button: Optimize overflow styles (WordPress/gutenberg#78300) - [ui] Select: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78372) - Grid: tiled grid overlay (WordPress/gutenberg#78373) - useCopyToClipboard: Always call onSuccess callback (WordPress/gutenberg#78387) - Remove commander.js file from the project (WordPress/gutenberg#78400) - [ui] Autocomplete: Default portal container to the wp compat overlay slot (WordPress/gutenberg#78375) - Use WCTooltip alias for component Tooltip imports (WordPress/gutenberg#78396) - Upload Media: pick up the finalized attachment URL so srcset renders (WordPress/gutenberg#78359) - UI: Fix item popup typography (WordPress/gutenberg#78403) - RTC: Add command to run in WebSockets mode (WordPress/gutenberg#78363) - Publishing packages: defer pushing tags until lerna publish succeeds (WordPress/gutenberg#78253) - Fix: Show collaborators with top toolbar is active (WordPress/gutenberg#78049) - Image block: Add "Mark as decorative" toggle for accessibility (WordPress/gutenberg#78064) - Revisions: Use CSS outline as secondary non-color indicator for diff blocks (WordPress/gutenberg#78393) - DataViewsPicker Table: Fix first-click row selection (WordPress/gutenberg#78423) - Fixed additional issues with block registration types (WordPress/gutenberg#78416) - Media Editor: Make zoom floor coverage-aware instead of fixed at 1x (WordPress/gutenberg#78222) - Grid: animate sibling tiles when layout reflows during drag or resize (WordPress/gutenberg#78395) - Widget Types: declarative presentation hint (full-bleed support) (WordPress/gutenberg#78209) - Image: Fix missing aria-label on lightbox trigger button for single images (WordPress/gutenberg#78426) - Columns: Remove redundant Skip option from layout picker (WordPress/gutenberg#78405) - Components: Popover: don't close when focus moves into the `@wordpress/ui` compat overlay slot (WordPress/gutenberg#78407) - Script Loader: Defer single-page admin init until DOMContentLoaded (Trac WordPress/gutenberg#65103) (WordPress/gutenberg#78136) - Grid: fix immutability lint warning for react hook (WordPress/gutenberg#78431) - Tabs, TabPanel: Align styles with wp-ui (WordPress/gutenberg#78418) - List View: Place caret at end of block when selecting (WordPress/gutenberg#76797) - Dashboard: restrict widget icons to just SVGs (no dashicons) (WordPress/gutenberg#78440) - Dashboard: Increase widget spacing with --wp-grid-gap. (WordPress/gutenberg#78439) - RTC: Provide `PROTOCOL_MISMATCH` error handling (WordPress/gutenberg#76991) - Dashboard: add chrome UI tools to widgets (WordPress/gutenberg#78060) - Experiment: Update Classic block deprecation notice (WordPress/gutenberg#78445) - UI Tabs: Recommend component for use (WordPress/gutenberg#78442) - RTC: Sync the content even if its a function (WordPress/gutenberg#76796) - Theme: Move token structure descriptions into tokens document (WordPress/gutenberg#78438) - Fix persistCRDTDoc minimal save payload (WordPress/gutenberg#77050) - useDialog: handle Escape via React `onKeyDown` so cascade works through portals (WordPress/gutenberg#78433) - Fix inconsistencies in feature selector processing part 1: global styles (WordPress/gutenberg#78276) - Media: Add undo snackbar for media editor image edits (WordPress/gutenberg#78425) - Media Fields: Fix filename truncation with Tooltip (WordPress/gutenberg#78453) - Media Editor Modal: Fix unexpected tab stop on date fields in the Details sidebar (WordPress/gutenberg#78454) - Add experiment to show admin bar in Post and Site Editor (WordPress/gutenberg#77964) - Visually align `Notice` from `@wordpress/components` with `Notice` from `@wordpress/ui` (WordPress/gutenberg#78231) - Widgets: Declare dependencies in a per-widget package.json (WordPress/gutenberg#78463) - Grid: don't allow resizing tile beyond min row height or column width (WordPress/gutenberg#78402) - UI Autocomplete: Fix prop types (WordPress/gutenberg#78450) - @wordpress/ui: Compat overlay slot — viewport-sized containing block (WordPress/gutenberg#78441) - Fix image upload crashes (WordPress/gutenberg#76707) - Theme: Add Tokens "Introduction" Storybook page (WordPress/gutenberg#78449) - Blocks: Share window listeners across instances (block props, rich text, ...) (WordPress/gutenberg#78310) - UI Button: Fix disabled cursor style (WordPress/gutenberg#78479) - Add welcome dashboard widget with adaptive layout and content (WordPress/gutenberg#78461) - Responsive block instance styles (WordPress/gutenberg#78384) - REST: Guard `setAccessible()` behind PHP < 8.1 in block-editor settings controller (WordPress/gutenberg#78478) - Docs: Update iframe editor migration guide for WordPress 7.0/7.1 (WordPress/gutenberg#78401) - Fix inconsistencies in feature selector processing part 2: pseudo block instances (WordPress/gutenberg#78326) - Media Editor Experiments: Tidy up by removing old pathways to the media editor experiment (WordPress/gutenberg#78489) - Compose: Simplify subscribeDelegatedListener root detection (WordPress/gutenberg#78492) - Dashboard: use Page hasPadding prop for content spacing (WordPress/gutenberg#78469) - Grid: hide resize handles and actions while on tile is resizing (WordPress/gutenberg#78391) - Dashboard Widgets: Add content-bleed presentation variant (WordPress/gutenberg#78491) - Dashboard: forbid non-module stylesheets in experimental, new widgets (WordPress/gutenberg#78496) - Revisions: Increase diff marker stripe contrast to 75% primary color proportion (WordPress/gutenberg#78473) - Fix flaky e2e test with dataview kbd navigation (WordPress/gutenberg#78503) - Theme: Update color space registration to avoid side effects (WordPress/gutenberg#77653) - Move PHP Sync Issue Generator file to @wordpress/release-tools (WordPress/gutenberg#78456) - ESLint: Support private API component denylist (WordPress/gutenberg#78451) - Widgets: Add TypeScript project config (WordPress/gutenberg#78467) - Dashboard: small changes to header (WordPress/gutenberg#78513) - Edit post: consume preload cache before React mount (WordPress/gutenberg#78508) - Vips: Remove dead batchResizeImage and vipsBatchResizeImage exports (WordPress/gutenberg#77975) - Automated Testing: Enable concurrency for ESLint (WordPress/gutenberg#78360) - Simplify component ESLint rules and extend to routes/widgets (WordPress/gutenberg#78519) - Image editor: remove unnecessary __nextHasNoMarginBottom prop (WordPress/gutenberg#78530) - RTC: Limit CRDT meta data to REST API edit context (WordPress/gutenberg#78531). - Update plugin release docs and edit for clarity. (WordPress/gutenberg#78537) - Updated the BlockAttribute typedef to allow for multi-type attributes (WordPress/gutenberg#78517) - Refactor media editor crop state into composite reducer (WordPress/gutenberg#78480) - Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim (WordPress/gutenberg#78484) - Font Library: clarify active variant state in Library tab (WordPress/gutenberg#78501) - Guard PHP unit test to avoid failures on old wp versions (WordPress/gutenberg#78547) - Fix block preview for responsive style states (WordPress/gutenberg#78538) - Breadcrumbs block: Hide separator from screen readers (WordPress/gutenberg#78524) - Preload: Backport user global styles entry for classic themes on WP 6.9 (WordPress/gutenberg#78546) - Guidelines: Refine access policy (WordPress/gutenberg#78296) - Fix flaky media upload save lock test (WordPress/gutenberg#78544) - Add `Quick post` widget (WordPress/gutenberg#78408) - Tooltip migration: block-editor + block-directory consumers (1/5) (WordPress/gutenberg#78411) - Navigation: Hard deprecate component (WordPress/gutenberg#78529) - Post Taxonomies: Drop redundant `per_page: -1` from taxonomy queries (WordPress/gutenberg#78569) - Dashboard: add elevation to widget actionable area (WordPress/gutenberg#78563) - Add dashboard Activity widget (WordPress/gutenberg#78552) - Components: Remove deprecated `__experimentalApplyValueToSides` export (WordPress/gutenberg#78528) - IconButton: Fix `focusableWhenDisabled` default (WordPress/gutenberg#78526) - Add cherry-pick script and update release tools in package.json (WordPress/gutenberg#78560) - Theme: Remove and prevent dependency grouping comments (WordPress/gutenberg#78573) - Dashboard: per-instance widget settings drawer (WordPress/gutenberg#78465) - Dashboard Widgets: Adapt Quick Draft to its tile size with a recent drafts list (WordPress/gutenberg#78572) - Add dashboard Site Preview widget (WordPress/gutenberg#78556) - Edit Post Preload: Cover remaining bound GET/OPTIONS requests on load (WordPress/gutenberg#78565) - Several improvements to the Dependabot configuration (WordPress/gutenberg#78536) - Fix: Disable collab sync when incompatible meta boxes are present. (WordPress/gutenberg#78145) - Bump the github-actions group across 2 directories with 6 updates (WordPress/gutenberg#78585) - Editor / Block Editor: Lazy-fetch user pattern categories (WordPress/gutenberg#78568) - RTC: Fix every update block refresh when a peer edits with in the code editor (WordPress/gutenberg#78483) - Edit Post: Hoist setupEditor to run before root.render (WordPress/gutenberg#78581) - Automated Testing: Fix and use built-in mechanism for flagging unused disables (WordPress/gutenberg#78313) - Remove dependency used for counting available CPUs (WordPress/gutenberg#78593) - ESLint: Restrict deprecated __nextHasNoMarginBottom prop (WordPress/gutenberg#78579) - Reset zoom level on component unmount (WordPress/gutenberg#69087) - Add missing package file to the site preview widget (WordPress/gutenberg#78583) - Add dashboard Site Health widget (WordPress/gutenberg#78555) - fix: discard unsaved HTML block changes on cancel (WordPress/gutenberg#78580) - Global styles revisions: ensure stylebook shows revision previews (WordPress/gutenberg#78490) - Docs: Update media editor documentation (WordPress/gutenberg#78617) - RTC: Fix Edit/Join row action invisible on mobile in post list (WordPress/gutenberg#78597) - Grid: animate tile removals (WordPress/gutenberg#78542) - Paste: keep `<img>` inside `<a>` when pasting plain-text HTML (WordPress/gutenberg#78015) - Deduplicate useGlobalStyles hook code (WordPress/gutenberg#78577) - Dashboard: add command palette commands (WordPress/gutenberg#78429) - Docs: Add Workspace Development guide (WordPress/gutenberg#78615) - add default widget instances to dashboard (WordPress/gutenberg#78622) - scale widget picker preview to fill slot (WordPress/gutenberg#78602) - Welcome widget: draw the version number in the banner (WordPress/gutenberg#78611) - Classic Block: Use `get_post()` in `wp_declare_classic_block_necessary` (WordPress/gutenberg#78613) - fix widget content overflowing its grid tile (WordPress/gutenberg#78627) - Fix: Register user-defined taxonomies after user-defined post types (WordPress/gutenberg#78497) - Image: Preserve width/height when converting Classic blocks to blocks (WordPress/gutenberg#78610) - Dashboard: mobile improvements (WordPress/gutenberg#78522) - Grid & Dashboard: polish dashboard drag preview motion, elevation, and drop exit (WordPress/gutenberg#78348) - Welcome widget: add a subtle shine to the version digits (WordPress/gutenberg#78626) - WP Editor Meta Box e2e: wait for TinyMCE init (WordPress/gutenberg#78631) - Quick Draft widget: layout, empty state, and style refinements (WordPress/gutenberg#78601) - Dashboard: Refine widget actionable area toolbar styling (WordPress/gutenberg#78578) - Components: Add Badge text overflow e2e story (WordPress/gutenberg#78589) - UI: Update Autocomplete clear disabled state (WordPress/gutenberg#78520) - Dashboard: tune default grid settings and starter layout (WordPress/gutenberg#78633) - RangeControl: Remove erroneous `icon` prop from web types (WordPress/gutenberg#78444) - UI: Add Button variant states e2e story (WordPress/gutenberg#78634) - DataViews: Fix wrapper height resolution in flex layouts (WordPress/gutenberg#76945) - Tooltip migration: editor + edit-post + edit-site consumers (2/5) (WordPress/gutenberg#78466) - Add dashboard News widget (WordPress/gutenberg#78554) - Add support for layout responsive styles (WordPress/gutenberg#78543) - Build Tools: Move build scripts to `@wordpress/build-scripts` workspace package (WordPress/gutenberg#78509) - Dashboard: fix widget rendering on the masonry grid (WordPress/gutenberg#78645) - Tooltip migration: dataviews consumers (3/5) (WordPress/gutenberg#78470) - Upgrade to React 19 (WordPress/gutenberg#61521) - Dashboard: use fully-specified fast-deep-equal import (WordPress/gutenberg#78660) - Hide block variation selector when style state is selected (WordPress/gutenberg#78658) - Migrate `create-test-block.sh` to `@wordpress/validation-tools` workspace (WordPress/gutenberg#78665) - Docs: Mark React Native mobile editor as unmaintained on trunk after React 19 upgrade (WordPress/gutenberg#78673) - Dashboard: URL bar in site preview widget (WordPress/gutenberg#78656) - UI Button: Fix pressed disabled styles for neutral minimal (WordPress/gutenberg#78635) - Dashboard: prevent pointer events in widget selection (WordPress/gutenberg#78681) - Block Inserter: Animate inserter button icon to signal open state. (WordPress/gutenberg#78306) - Guidelines: Add data-slug attribute to settings list items (WordPress/gutenberg#78676) - Validate additional CSS on mount (WordPress/gutenberg#78682) - Move @emotion deps out of root package.json (WordPress/gutenberg#78687) - Media Editor Modal: Tighten labels for crop handles toggle (WordPress/gutenberg#78703) - Media Editor: make the modal the default crop experience (WordPress/gutenberg#78653) - Media Editor Modal: Update the rotation ruler to use a vertical line marker (WordPress/gutenberg#78704) - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Update browserslist (WordPress/gutenberg#78840) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65560. git-svn-id: https://develop.svn.wordpress.org/trunk@62583 602fd350-edb4-49c9-b593-d223f7449a82
- Backport package version bump (WordPress/gutenberg#79676) - Revisions: Use CSS outline as secondary non-color indicator for diff blocks (WordPress/gutenberg#78393) - Editor: Move focus to revisions slider when entering revisions mode (WordPress/gutenberg#79691) - Avoid dirtying related navigation entities during passive render (WordPress/gutenberg#79000) - Navigation: Use block context to determine whether Page List is nested in Submenu (WordPress/gutenberg#79048) - Mark all controlled/mode block changes non-persistent (WordPress/gutenberg#79350) - Fix wp/7.0 cherry-pick lint errors (WordPress/gutenberg#79737) - Custom HTML: Fix scrollbar after tab switch in modal (WordPress/gutenberg#78571) - Template Part: Remove restriction on tabs / inspector fills (WordPress/gutenberg#79181) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim (WordPress/gutenberg#78484) - Guard PHP unit test to avoid failures on old wp versions (WordPress/gutenberg#78547) - Image: Fix missing aria-label on lightbox trigger button for single images (WordPress/gutenberg#78426) - useCopyToClipboard: Always call onSuccess callback (WordPress/gutenberg#78387) - Block Editor: Fix blockGap fallback parsing for nested var() values (WordPress/gutenberg#77750) - Backport: Navigation shared icon rendering functions to wp/7.0 (WordPress/gutenberg#79754) Reviewed-by cbravobernal. Fixes #65566. git-svn-id: https://develop.svn.wordpress.org/branches/7.0@62610 602fd350-edb4-49c9-b593-d223f7449a82
- Backport package version bump (WordPress/gutenberg#79676) - Revisions: Use CSS outline as secondary non-color indicator for diff blocks (WordPress/gutenberg#78393) - Editor: Move focus to revisions slider when entering revisions mode (WordPress/gutenberg#79691) - Avoid dirtying related navigation entities during passive render (WordPress/gutenberg#79000) - Navigation: Use block context to determine whether Page List is nested in Submenu (WordPress/gutenberg#79048) - Mark all controlled/mode block changes non-persistent (WordPress/gutenberg#79350) - Fix wp/7.0 cherry-pick lint errors (WordPress/gutenberg#79737) - Custom HTML: Fix scrollbar after tab switch in modal (WordPress/gutenberg#78571) - Template Part: Remove restriction on tabs / inspector fills (WordPress/gutenberg#79181) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Navigation: Restore block_core_navigation_submenu_render_submenu_icon() as deprecated shim (WordPress/gutenberg#78484) - Guard PHP unit test to avoid failures on old wp versions (WordPress/gutenberg#78547) - Image: Fix missing aria-label on lightbox trigger button for single images (WordPress/gutenberg#78426) - useCopyToClipboard: Always call onSuccess callback (WordPress/gutenberg#78387) - Block Editor: Fix blockGap fallback parsing for nested var() values (WordPress/gutenberg#77750) - Backport: Navigation shared icon rendering functions to wp/7.0 (WordPress/gutenberg#79754) Reviewed-by cbravobernal. Fixes #65566. Built from https://develop.svn.wordpress.org/branches/7.0@62610 git-svn-id: http://core.svn.wordpress.org/branches/7.0@61890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
What
Restores
block_core_navigation_submenu_render_submenu_icon()as a deprecation shim and removes the backwards-incompatibility introduced by #74853.Why
In #74853 the function was removed from
packages/block-library/src/navigation-submenu/index.phpas part of consolidating submenu icon rendering into the new shared helperblock_core_shared_navigation_render_submenu_icon(). The removal landed without a_deprecated_function()notice or a backwards-compatible alias.Once that change synced into Core (wordpress-develop #10865, scheduled for WordPress 7.0), any theme or plugin that called the function — for example from a
render_block_core/navigation-submenufilter to customise the dropdown chevron — started triggering a fatal PHP error.Trac ticket: https://core.trac.wordpress.org/ticket/65287
How
packages/block-library/src/navigation-submenu/index.php— the same file the original was first deleted from.Wrapped in afunction_existsguard so a future Core sync that brings the shim back to Core itself doesn't double-declare._deprecated_function()so callers see actionable guidance to migrate to the new shared helper, and returns the new helper's output to preserve the rendered markup.gutenberg_-prefixed name (matching the build's plugin output and the existingblock-navigation-link-variations-test.phpconvention).Notes for reviewers
The build's
gutenberg_prefix transform (packages/wp-build/lib/build.mjs:413-422) applies to plugin builds but is skipped for Core (IS_WORDPRESS_COREbranch at L392-397). That means:block_core_navigation_submenu_render_submenu_icon()unprefixed — fixes the fatal on standalone Core installs.gutenberg_block_core_navigation_submenu_render_submenu_icon(). On WP 7.0+ + plugin, theme calls to the unprefixed name resolve to Core's shim (once synced), so the bug is fixed there too.Testing Instructions
block_core_navigation_submenu_render_submenu_icon()(e.g. inside arender_block_core/navigation-submenufilter).block_core_shared_navigation_render_submenu_icon().Also runnable:
phpunit --filter Block_Core_Navigation_Submenu_Render_Submenu_Icon_Test.Screenshots or screencast
N/A — backend-only change with no UI impact.
Types of changes
Bug fix (backwards-compatible).
Checklist