Add xl border radius token for page shell surfaces.#78913
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍 Logic tracks, verified in Site Editor & Fonts page, and searched other instances of border-radius in boot, edit-site, and admin-ui.
5674a1f to
83d87d5
Compare
|
Size Change: +63 B (0%) Total Size: 8.59 MB 📦 View Changed
|
|
Flaky tests detected in c293deb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27413277646
|
|
Not blocking this. But a brief moment of pause and reflection—the math checks out, but I think it's worth asking whether the page should be so rounded after all. Consider that we are looking to potentially replace the default 2px corner radius for buttons and inputs with 4px, which whould shift the entire range. Presumably we'd be looking at a 16px outer corner radius for the page itself. Does that get too bubbly? I suspect the answer is: no, it's fine. But is there a way we can quickly gut-check this with a sketched visual before we land this? |
|
I don't think the value of a token in the default scale needs to prescribe the value in a different scale. In other words, if the If we agree the new |
ciampo
left a comment
There was a problem hiding this comment.
Technically, this is good to go after remaining feedback is addressed + a rebase.
Merging will depend on design feedback
83d87d5 to
2d74d6a
Compare
|
I see a 👍 from @jasmussen, but will wait for a green check before merging. |
| ### New Features | ||
|
|
||
| - Add `--wpds-dimension-size-*` design tokens for element sizing ([#76545](https://github.com/WordPress/gutenberg/pull/76545)). | ||
| - Add `--wpds-border-radius-xl` for page and app shell surfaces so nested cards and notices can stay on `--wpds-border-radius-lg` without matching the parent radius ([#78913](https://github.com/WordPress/gutenberg/pull/78913)). |
There was a problem hiding this comment.
We may want to rebase, move CHANGELOG to latest unreleased section before merging
Extend the WPDS radius scale with --wpds-border-radius-xl (12px) so outer admin shells can use a larger corner radius than nested cards and notices on lg. Apply the token in boot layout, site editor layout, and the theme example story. Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Replace generic size labels with guidance on which UI surfaces each step is intended for. Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
Co-authored-by: Cursor <[email protected]>
2d74d6a to
c293deb
Compare
|
I'm going to merge this as it closes a gap in the tokens exposed by a genuine need in the design language. We can continue to iterate as needed :) |
What
Adds
--wpds-border-radius-xlto the WPDS border radius scale and uses it on outer admin page shell surfaces.Token & docs
xlstep inpackages/theme/tokens/border.jsonand regenerated prebuild artifactspackages/theme/docs/tokens.mdandpackages/theme/CHANGELOG.mdConsumers
boot-layout__stage,boot-layout__inspector, andboot-layout__canvas(desktop); view-transition pseudo-elements.edit-site-layout__areaand.edit-site-layout:not(.is-full-canvas) .edit-site-layout__canvas .edit-site-resizable-frame__inner-contentWhy
The WPDS design language calls for radius to scale with container size. However, page shells and contained surfaces (Card, Notice) share an 8px radius, so when the latter are nested within the former, the hierarchy is broken. See the Gutenberg Experiments page as an example.
Extending the scale upward (rather than shrinking cards/notices) keeps
lgaligned with the existing guidance for cards and modals.How
xs→sm→md→lg→xlvia Terrazzo; runnpm run build:tokensin@wordpress/theme.8px/$radius-largeon outer layout chrome withvar(--wpds-border-radius-xl).@wordpress/uiCard/Notice (stilllg).Screenshots
Note the radius of the shell is now one step larger than the radius of the nested cards.
Test plan
lg(8px)npm run build/ theme token build if CI requires fresh prebuild