Skip to content

BaseControl: add text-wrap: pretty#79112

Merged
juanfra merged 2 commits into
trunkfrom
try/fix-help-text-typographic-widow
Jun 12, 2026
Merged

BaseControl: add text-wrap: pretty#79112
juanfra merged 2 commits into
trunkfrom
try/fix-help-text-typographic-widow

Conversation

@jasmussen

Copy link
Copy Markdown
Contributor

What?

Pretty tiny PR to address an issue with BaseControl. The icon block revealed that there is a potential for typographic widows in the help text:
Skærmbillede 2026-06-11 kl  14 04 41

This PR adds text-wrap: pretty; to address that:

Skærmbillede 2026-06-11 kl  14 05 27

Why?

This improves legibility.

Testing Instructions

Insert the Icon block, pick an icon, and observe the help text in the inspector, it should not have a typographic widow.

Use of AI Tools

I used search, little else.

@jasmussen jasmussen requested review from ciampo and mirka June 11, 2026 12:08
@jasmussen jasmussen self-assigned this Jun 11, 2026
@jasmussen jasmussen requested review from a team and ajitbohra as code owners June 11, 2026 12:08
@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jasmussen <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: jameskoster <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Size Change: +13 B (0%)

Total Size: 8.59 MB

📦 View Changed
Filename Size Change
build/scripts/components/index.min.js 264 kB +13 B (0%)

compressed-size-action

@juanfra juanfra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. LGTM!

Do we want to make a pass on other help text styles to unify this? If so, can definitely be separate from this.

@jasmussen

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I feel like this should cover most bases, what am I forgetting?

@github-actions

Copy link
Copy Markdown

Flaky tests detected in e5884fe.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27345756500
📝 Reported issues:

@jameskoster

Copy link
Copy Markdown
Contributor

Should we update Field as well?

@juanfra

juanfra commented Jun 11, 2026

Copy link
Copy Markdown
Member

I feel like this should cover most bases, what am I forgetting?

True, it covers most cases. We could consider updating Field, I can open a new PR for that if we want to expedite this one.

@juanfra juanfra merged commit 194bb9e into trunk Jun 12, 2026
45 checks passed
@juanfra juanfra deleted the try/fix-help-text-typographic-widow branch June 12, 2026 07:41
@github-actions github-actions Bot added this to the Gutenberg 23.5 milestone Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] Components /packages/components [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants