Skip to content

[DataViewsPicker]: DataViewsPicker.BulkActionToolbar now renders only the bulk-selection info and action buttons#79180

Merged
ntsekouras merged 1 commit into
trunkfrom
try/dataviews-picker-footer
Jun 15, 2026
Merged

[DataViewsPicker]: DataViewsPicker.BulkActionToolbar now renders only the bulk-selection info and action buttons#79180
ntsekouras merged 1 commit into
trunkfrom
try/dataviews-picker-footer

Conversation

@ntsekouras

@ntsekouras ntsekouras commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

What?

Extracted from #77333 (comment)

While working in updating the revisions screens to use the picker-activity layout I noticed a few things we could improve around the exports and organization of the footer components.

These changes will help more use cases and enable better composition and some more will be explored separately when we'll try to integrate this layout in GS revisions.

This PR extracts:

  1. In trunk DataViewsPicker.BulkActionToolbar exports the footer, which is not correct. So I followed a similar approach to DataViews and created (and exported) BulkActionToolbar which holds the selection checkbox, the message, and the actions. It doesn't contain the pagination and is more flexible for free composition.
  2. Fixed a logic bug in useIsMultiselectPicker where we wouldn't check the existence of actions, which also could lead to wrong aria props.
  3. Exported the footer. This component is the one that is going to be used by the revisions (other PR).

Testing Instructions

  1. No visible changes anywhere. Everything should work as before
  2. You can confirm in storybook (npm run storybook:dev) or existing picker usages like the media picker

@ntsekouras ntsekouras self-assigned this Jun 15, 2026
@ntsekouras ntsekouras added [Type] Breaking Change For PRs that introduce a change that will break existing functionality [Package] DataViews /packages/dataviews labels Jun 15, 2026
@github-actions github-actions Bot added the [Package] Media Utils /packages/media-utils label Jun 15, 2026
…ly the bulk-selection info and action buttons
@ntsekouras ntsekouras force-pushed the try/dataviews-picker-footer branch from 3905f32 to c69b91a Compare June 15, 2026 07:54
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Size Change: +156 B (0%)

Total Size: 8.59 MB

📦 View Changed
Filename Size Change
build/modules/content-types/index.min.js 159 kB +2 B (0%)
build/scripts/edit-site/index.min.js 297 kB +11 B (0%)
build/scripts/editor/index.min.js 470 kB +2 B (0%)
build/scripts/media-utils/index.min.js 114 kB +141 B (+0.12%)

compressed-size-action

@Mamaduka Mamaduka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ntsekouras!

This tests well for me in Storybook, and refactoring makes sense.

@ntsekouras ntsekouras merged commit c558d9d into trunk Jun 15, 2026
45 checks passed
@ntsekouras ntsekouras deleted the try/dataviews-picker-footer branch June 15, 2026 08:45
@github-actions github-actions Bot added this to the Gutenberg 23.5 milestone Jun 15, 2026
@bgrgicak bgrgicak added [Type] Enhancement A suggestion for improvement. and removed [Type] Breaking Change For PRs that introduce a change that will break existing functionality labels Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] DataViews /packages/dataviews [Package] Media Utils /packages/media-utils [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants