[DataViewsPicker]: DataViewsPicker.BulkActionToolbar now renders only the bulk-selection info and action buttons#79180
Merged
Conversation
…ly the bulk-selection info and action buttons
3905f32 to
c69b91a
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +156 B (0%) Total Size: 8.59 MB 📦 View Changed
|
Mamaduka
approved these changes
Jun 15, 2026
Mamaduka
left a comment
Member
There was a problem hiding this comment.
Thanks, @ntsekouras!
This tests well for me in Storybook, and refactoring makes sense.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Extracted from #77333 (comment)
While working in updating the revisions screens to use the picker-activity layout I noticed a few things we could improve around the exports and organization of the footer components.
These changes will help more use cases and enable better composition and some more will be explored separately when we'll try to integrate this layout in GS revisions.
This PR extracts:
DataViewsPicker.BulkActionToolbarexports the footer, which is not correct. So I followed a similar approach to DataViews and created (and exported) BulkActionToolbar which holds the selection checkbox, the message, and the actions. It doesn't contain the pagination and is more flexible for free composition.useIsMultiselectPickerwhere we wouldn't check the existence of actions, which also could lead to wrong aria props.Testing Instructions
npm run storybook:dev) or existing picker usages like the media picker