Theme: Skip serializing data-wpds-root-provider="false" on non-root providers#79253
Merged
Conversation
Only set the attribute when isRoot is true, so React drops it on non-root providers instead of serializing it as "false".
23 tasks
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 8.6 MB 📦 View Changed
|
mirka
reviewed
Jun 17, 2026
ciampo
commented
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
See #77462 (point I3).
Stops
ThemeProviderfrom renderingdata-wpds-root-provider="false"on every non-root provider.Why?
The attribute is only ever matched as
="true"(by the prebuilt CSS and the runtime selector). Serializing"false"on every non-root provider is just dead markup.How?
Set the attribute with
data-wpds-root-provider={ isRoot || undefined }so React omits it entirely whenisRootisfalse.Testing Instructions
<ThemeProvider>withoutisRootand confirm the wrapper<div>has nodata-wpds-root-providerattribute.<ThemeProvider isRoot>and confirm the wrapper<div>still hasdata-wpds-root-provider="true".npm run test:unit packages/theme.Use of AI Tools
This PR was authored with the assistance of AI tooling (Cursor); all changes were reviewed by me.