Classic Block: Port PHPUnit coverage for hiding it from the inserter#79434
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…essary Ports the unit tests added in the corresponding Core PR (wordpress-develop#11712) into Gutenberg so the two stay in sync, and aligns the function docblock with the @access private tag from Core. No behavior change.
3173891 to
716a025
Compare
Mamaduka
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports the PHPUnit coverage for
wp_declare_classic_block_necessary()from the corresponding Core PR (wordpress-develop#11712) into Gutenberg, so the two stay in sync.WP_Script_Loader_Testcovering the default (hidden) behavior, opting in via thewp_classic_block_supports_inserterfilter, and the post being passed to the filter.@access privatetag from Core.Why
The function shipped in Gutenberg (#77911, #78613) without PHP test coverage, while Core PR WordPress/wordpress-develop#11712 added tests for it. This brings that coverage back so the implementations stay aligned.
No behavior change.
Testing Instructions
All 3 tests should pass.
Use of AI Tools
Opus 4.8