[all components] Fix render prop warning false positive#4363
Merged
Conversation
Contributor
Author
Codex ReviewOverviewThis patch narrows the render prop warning so uppercase constant callbacks like Findings (None)No blocking issues found in this patch. Confidence: 4/5High confidence based on a full pass over the branch diff, targeted inspection of the warning heuristic and regression tests, and successful runs of Notes
|
commit: |
Bundle size report
Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4361
Summary
This narrows the development-only render prop warning so constant-style callbacks such as
DEFAULT_RENDERno longer trigger a false positive. The warning still catches component-like names, including PascalCase names with acronym prefixes.Changes